Skip to content

Sort endpoints in validation stats for deterministic output#8

Merged
daniel-gomm merged 2 commits into
devfrom
copilot/sub-pr-7
Feb 10, 2026
Merged

Sort endpoints in validation stats for deterministic output#8
daniel-gomm merged 2 commits into
devfrom
copilot/sub-pr-7

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 10, 2026

endpoints_used was built from a set and converted directly to list, producing nondeterministic ordering that made stats output unstable across runs.

Changes

  • Sort endpoints alphabetically before storing in stats["endpoints_used"] (line 171)
  • Sort endpoints in mixed endpoint warning message for consistency (line 183)
# Before
result.stats["endpoints_used"] = list(endpoints)

# After  
result.stats["endpoints_used"] = sorted(endpoints)

This ensures stable output for testing and comparison while maintaining the same API.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: daniel-gomm <63717948+daniel-gomm@users.noreply.github.com>
Copilot AI changed the title [WIP] Update to address feedback from review on version 0.0.4 Sort endpoints in validation stats for deterministic output Feb 10, 2026
Copilot AI requested a review from daniel-gomm February 10, 2026 09:36
@daniel-gomm daniel-gomm marked this pull request as ready for review February 10, 2026 09:40
Copilot AI review requested due to automatic review settings February 10, 2026 09:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes validation statistics and warning output deterministic by sorting endpoint lists derived from a set, avoiding run-to-run ordering instability.

Changes:

  • Sort endpoints_used before storing it in result.stats for stable stats output.
  • Sort the endpoint list in the “mixed endpoints” warning message for consistent messaging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@daniel-gomm daniel-gomm merged commit 3f70abc into dev Feb 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants