Fix endless re-transmissions when num_xfers > 1 - #46
Open
kodidu wants to merge 1 commit into
Open
Conversation
Single xfer with 2 bytes: OK mcp2210-util -D /dev/spidevX spi 9800 // SPI_IOC_MESSAGE(1) Two xfers with 1 byte: ERROR endless transmission mcp2210-util -D /dev/spidevX spi 98,00 // SPI_IOC_MESSAGE(2) cmd->xfer is not updated after the first xfer finished => endless transmission Looks like commit c4f83f1 introduced this issue: daniel-santos@c4f83f1#diff-0215cfa293de9d1a72422d837fa2be64c49391dfb2835b99adb31403298f0206L772
Owner
|
Thank you for your patch! I'll try to review and test in the next few days. |
|
@daniel-santos any updates? |
Author
|
@iDoka I only can suggest you to step away from the MCP2210. This is a very poorly designed communication IC... |
|
@kodidu any alternative candidate to SPI -to-USB bridge with good works on Linux? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single xfer with 2 bytes: OK
mcp2210-util -D /dev/spidevX spi 9800 // SPI_IOC_MESSAGE(1)
Two xfers with 1 byte: ERROR endless transmission
mcp2210-util -D /dev/spidevX spi 98,00 // SPI_IOC_MESSAGE(2)
cmd->xfer is not updated after the first xfer finished => endless transmission
Looks like commit c4f83f1 introduced this issue:
c4f83f1#diff-0215cfa293de9d1a72422d837fa2be64c49391dfb2835b99adb31403298f0206L772