test(holdings): execute ScreenRestated end-to-end against ParadeDB - #4408
Merged
Conversation
…ing slices against ParadeDB The split-aware screener path shipped with unit coverage of its pure in-memory half only; nothing ever executed the pctPassthroughIds Contains predicates or the per-(stock, ListedTicker) slices GroupBy against a real database. These two tests prove translation and behaviour for the case the path exists for: a reverse split after the screened quarter (passthrough + restated re-judgement, restated-fail rows dropped, unaffected stocks still SQL-filtered) and a sibling listing's slice surviving the primary-series split as filed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4407. The split-aware screener merged with its two EF constructs never executed: the % of float passthrough predicates (
pctPassthroughIds.Contains(...) || ...) and the per-listing slices query (GroupBy(h => new { h.CommonStockId, h.ListedTicker })). An untranslatable EF query passes build and unit tests, and this branch only fires at runtime when a stock has split since the screened quarter, exactly the moment it was built for.Two integration tests in
InstitutionalHoldingRepositoryScreenTests:Test-only, no production code touched. Both pass against the ParadeDB fixture (class 9/9).