Stop publishing a hosted tool count this repo cannot keep true - #4416
Open
daniel3303 wants to merge 1 commit into
Open
Stop publishing a hosted tool count this repo cannot keep true#4416daniel3303 wants to merge 1 commit into
daniel3303 wants to merge 1 commit into
Conversation
The README stated the hosted server's total and the gap between it and this build. Both drifted: the hosted server has moved on and the stated difference was never updated, so the page quoted three numbers of which one was right. State only the self-hosted count, which this repo can prove, and pin it with a test that counts the tools reflection actually finds. Cloud is described as adding more on top rather than by a number nothing here can verify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README stated the hosted server's total (108) and the difference between it and this build (44 more). Both had drifted: the hosted server is at 111 today, so the stated gap was wrong too. Three numbers were published and only the self-hosted 64 was still right.
PublishedToolCountTests, which counts the tools reflection actually finds and asserts the README publishes that number in both places it appears. Mutation-tested: bumping the README to 65 fails the test.EnumerateToolsinMcpToolAnnotationsTestsis widened tointernalso the new guard reuses the existing enumerator rather than growing a second one.4,440 unit tests pass.