Move pure playback types into SentryReplay.Data#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Relocates the provider-agnostic playback types out of the WPF app project and into the existing
SentryReplay.Dataclass library, so pure logic lives behind a compile-time boundary that cannot acquire WPF/Flyleaf dependencies.Moved
SentryReplay/Playback/→SentryReplay.Data/Playback/:ClipTimeline.cs,ClipTimelinePosition.cs— pure timeline math (no usings)CameraPlayerEvents.cs—EventArgswrappers (no usings)ICameraPlayer.cs— the playback abstraction seam (no usings)ClipPlaylist.cs— clip selection state; usesSerilogStayed in the app (
SentryReplay/Playback/):FlyleafCameraPlayer.csandVideoPlayerController.cs— both are genuinely Flyleaf/MVVM-coupled.SentryReplay.Data.csproj: added<PackageReference Include="Serilog" Version="4.2.0" />(matches the app's version) — required becauseClipPlaylistlogs via Serilog. Without it the move would not compile.Why this is safe / cheap
SentryReplay;across both projects (noRootNamespaceoverride), so the files compile unchanged after the move — no namespace, XAML, or test edits needed.SentryReplay.Data, soVideoPlayerController/FlyleafCameraPlayerstill seeICameraPlayerand the pure types (app → Data). Tests already reference Data, soFakeCameraPlayer : ICameraPlayerstill resolves.git mv(tracked as renames, history preserved).Verification
Full solution builds clean (0 warnings/errors); all 81 tests pass;
dotnet formatclean.Notes
Data→Domain(naming churn, no payoff) and does not create per-feature slice folders.AGENTS.mdso the "preserve existing MVVM patterns" guidance no longer sanctions the old god-file pattern.