Repository navigation
Lock agent-tools/cli only in the root lockfile - #34
Open
danielcorin wants to merge 2 commits into
Open
danielcorin wants to merge 2 commits into
danielcorin wants to merge 2 commits into
Conversation
agent-tools/cli is a workspace of the root package, so Dependabot's separate /agent-tools entry produced PRs that bumped the CLI manifest and agent-tools/package-lock.json but not the root lockfile, breaking npm ci in CI (#26, #28). Nothing installs from the agent-tools lockfile; it was only audited. Drop the /agent-tools Dependabot entry so the root entry handles the CLI, delete the redundant lockfile, stop it from being regenerated, and rely on the root npm audit, which covers all workspaces.
# Conflicts: # agent-tools/package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent-tools/cliis a workspace of the root package, but Dependabot also had a separate/agent-toolsnpm entry. Its PRs bumped the CLI manifest andagent-tools/package-lock.jsonbut not the rootpackage-lock.json, sonpm cifailed in every CI job (#26, #28).Nothing installs from
agent-tools/package-lock.json. Every install, build, and release path runsnpm ciat the root. The only thing that used the file was thenpm --prefix agent-tools auditCI step.Changes
.github/dependabot.yml: remove the/agent-toolsnpm entry. The root entry already updates workspace manifests (that's howclient/andapi/bumps work), so CLI dependency bumps will now update the root lockfile.agent-tools/package-lock.json, and addagent-tools/.npmrcwithpackage-lock=falseso runningnpm installthere doesn't recreate it.npm --prefix agent-tools audit. Rootnpm auditcovers all workspaces, includingagent-tools/cli.Verification
agent-tools/cliand all its devDependencies.npm auditat the root: 0 vulnerabilities.npm --prefix agent-tools run check:cliand the precommit checks pass.Ordering
#26 and #28 modify
agent-tools/package-lock.json, which this PR deletes. Merge them first and then rebase this PR (dropping the lockfile again), or merge this first and close them; Dependabot will reopen equivalent bumps from the root entry.