feat: enforce conventional commits - #238
Merged
AnnoDomine merged 8 commits intoSep 19, 2026
Merged
AnnoDomine merged 8 commits into
AnnoDomine merged 8 commits into
Conversation
AnnoDomine
changed the base branch from
development
to
chore/contributor-workflow-and-docs
September 18, 2026 17:31
AnnoDomine
marked this pull request as draft
September 18, 2026 18:42
AnnoDomine
marked this pull request as ready for review
September 18, 2026 18:44
MarkVDD
reviewed
Sep 18, 2026
Co-authored-by: Mark van der Dam <39335084+MarkVDD@users.noreply.github.com>
AnnoDomine
requested review from
Airbag65 and
MarkVDD
and removed request for
MarkVDD and
mattsva
September 19, 2026 07:04
MarkVDD
approved these changes
Sep 19, 2026
Airbag65
approved these changes
Sep 19, 2026
Airbag65
left a comment
Collaborator
There was a problem hiding this comment.
Great addition @AnnoDomine!
AnnoDomine
merged commit Sep 19, 2026
2cb18f2
into
danieldeer:chore/contributor-workflow-and-docs
4 checks passed
Collaborator
|
Thats greate. I love it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configures and enforces
pre-commithooks for code quality and Conventional Commits 1.0.0 validation. Developers can now initialize the entire dev environment and hook setup in a single command usinguv run pre-commit install.Additional it includes the CI action for semantic pull request title, to enforce the PR titel follows the conventional commits for more easy merge of PRs.
Type of Change
Key Changes
.pre-commit-config.yamlwithdefault_install_hook_typesconfigured forpre-commitandcommit-msg.pre-committo dev dependencies inpyproject.tomlmanaged byuv.uv run pre-commit install).Validation
uv run pre-commit installin a clean environment..git/hooks/pre-commitand.git/hooks/commit-msgwere successfully created.git commit -m "bad commit message"git commit -m "docs: update contributing guide"uv run pre-commit run --all-filesgit commit -S -m "docs(guideline): added setup command and adjust branch policy in guidelines" uv-lock..............................................(no files to check)Skipped ty.......................................................................Passed pytest...................................................................Passed ruff.....................................................................Passed ruff-format..............................................................Passed uv-lock..............................................(no files to check)Skipped Conventional Commit......................................................PassedChecklist
uv run ruff check .anduv run ruff format --check ., or this PR does not change Python.Closes: #236