Skip to content

chore: remove http features - #246

Open
danieldeer wants to merge 3 commits into
chore/contributor-workflow-and-docsfrom
chore/remove-http-features
Open

chore: remove http features#246
danieldeer wants to merge 3 commits into
chore/contributor-workflow-and-docsfrom
chore/remove-http-features

Conversation

@danieldeer

@danieldeer danieldeer commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Key Changes

Validation

Checklist

  • I reviewed the diff and kept it focused on the described change.
  • Python changes pass uv run ruff check . and uv run ruff format --check ., or this PR does not change Python.
  • Changed behavior is covered by appropriate tests, including a regression test for bug fixes; any limitations are explained under Validation.
  • Validation lists the checks or manual flows I ran and their results.
  • Relevant documentation is updated, or no documentation change is needed.

@danieldeer

danieldeer commented Sep 19, 2026

Copy link
Copy Markdown
Owner Author

Any idea why the e2e test failed?

@AnnoDomine

AnnoDomine commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Any idea why the e2e test failed?

Yes.
Just remove the yaml.
It points to test files which are removed.

@AnnoDomine
AnnoDomine changed the base branch from main to development September 19, 2026 09:37
@AnnoDomine AnnoDomine linked an issue Sep 19, 2026 that may be closed by this pull request
Remove HTTP interface #234
Open
@AnnoDomine AnnoDomine changed the title Chore/remove http features chore: remove http features Sep 19, 2026
AnnoDomine
AnnoDomine suggested changes Sep 19, 2026
View reviewed changes

@AnnoDomine AnnoDomine left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing removal of Dockerfile as it is no more needed.
Missing changes to pyproject.toml and flask files.

As the changes are including information for install the package from PyPi, i wil change the targed and including the issue to the workflow updates because these are the changes which includes auto-release, versionising,...

Additional the commit messages should be cligned to follow "conventional commits".
It is not a thing which should be changed as it will be merged with a squashed merge.
The PR name i already aligned.

After i changed the target to the chore combined branch, please merge it to your branch and solve the merge conflicts.

@AnnoDomine
AnnoDomine changed the base branch from development to chore/contributor-workflow-and-docs September 19, 2026 10:04
@AnnoDomine

AnnoDomine commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

And do not forget to run uv run pre-commit install after you merged the target to your branch please.

@danieldeer

danieldeer commented Sep 19, 2026

Copy link
Copy Markdown
Owner Author

Why did you change the base branch @AnnoDomine ?
I understand merging into development, but what is chore/contributor-workflow-and-docs?

@danieldeer
danieldeer force-pushed the chore/remove-http-features branch from 41bcef2 to 754083c Compare September 19, 2026 12:46
@danieldeer

danieldeer commented Sep 19, 2026

Copy link
Copy Markdown
Owner Author

Done @AnnoDomine

MarkVDD
MarkVDD reviewed Sep 19, 2026
View reviewed changes

@MarkVDD MarkVDD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that uvicorn and main.py have been removed, we can also get rid of the Dockerfile imo.

The Nix development shell still installs fastapi, fastapi-cli and uvicorn, which are removed from the project by this PR. Could these be removed from the Nix environment as well?

Comment thread README.md

`seriousdb` is a small, simple key-value database you can query directly over HTTP. It requires zero configuration and is designed to be effortless.
For fullstack projects, `seriousdb` can replace your complete backend.
`seriousdb` is a small, simple key-value database you import directly into your Python project. It requires zero configuration and is designed to be effortless.

@MarkVDD MarkVDD Sep 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changed Markdown files contain lines longer than the new .editorconfig limit and inconsistent wrapping / formatting. Could you enable EditorConfig support in your editor and run:

uvx mdformat --wrap 100 README.md SECURITY.md docs

followed by:

uvx mdformat --check --wrap 100 README.md SECURITY.md docs

This should fix any inconsistencies in the markdown files.

@VihaanReddyM

VihaanReddyM commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

I agree, Docker is redundant. @danieldeer thoughts and also can I be replaced as the assigned maintainer for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@MarkVDD MarkVDD MarkVDD left review comments
@AnnoDomine AnnoDomine AnnoDomine requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove HTTP interface

4 participants

@danieldeer @AnnoDomine @VihaanReddyM @MarkVDD