Fix: Exit gracefully on already optimised files.#17
Open
cadesalaberry wants to merge 1 commit intodanielgtaylor:masterfrom
Open
Fix: Exit gracefully on already optimised files.#17cadesalaberry wants to merge 1 commit intodanielgtaylor:masterfrom
cadesalaberry wants to merge 1 commit intodanielgtaylor:masterfrom
Conversation
Exit gracefully on already optimised files.
cbenhagen
reviewed
Mar 22, 2019
| # No free atoms to process and moov is correct, we are done! | ||
| msg = "This file appears to already be setup!" | ||
| msg = "This file appears to be already optimised for streaming. Nothing to do." | ||
| log.error(msg) |
There was a problem hiding this comment.
Info log level should be enough in this case.
Suggested change
| log.error(msg) | |
| log.info(msg) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16.