feat(embedkit): add Result type and quantization-aware SameSpace guard - #85
Merged
Conversation
New embedkit package: Result{Vector, Source, Model, Dim, Quant} as the
shared embedding-provenance type, and SameSpace(a, b Result) bool as the
embedding-space identity guard. SameSpace distinguishes model,
quantization level, and dimension — a 4-bit MLX embedding and an
unquantized Ollama embedding of the same nominal model are different
spaces and must never compare as equal.
This is the foundation sub-issue of #74; the provider abstraction,
cache, and dimension-pinning sub-issues (#82, #83, #84) build on this
Result type.
Closes #81
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New embedkit package: Result{Vector, Source, Model, Dim, Quant} as the
shared embedding-provenance type, and SameSpace(a, b Result) bool as the
embedding-space identity guard. SameSpace distinguishes model,
quantization level, and dimension — a 4-bit MLX embedding and an
unquantized Ollama embedding of the same nominal model are different
spaces and must never compare as equal.
This is the foundation sub-issue of #74; the provider abstraction,
cache, and dimension-pinning sub-issues (#82, #83, #84) build on this
Result type.
Closes #81
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com