Repository navigation
Add background update downloads and prepare v0.1.15 - #43
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1f4386378
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cached.sourceBuild == sourceBuild, | ||
| UUID(uuidString: cached.filename) != nil, | ||
| cached.fileURL == directory.appendingPathComponent(cached.filename), | ||
| cached.hasExpectedSize | ||
| else { return nil } |
There was a problem hiding this comment.
When a cached update successfully installs, the next app build rejects its metadata because cached.sourceBuild != sourceBuild, but this path only returns nil and leaves both the archive and download.json on disk. Since cleanup otherwise happens only after another update is downloaded, users who remain on the newly installed version can retain an obsolete archive—up to the allowed 2 GB—indefinitely; remove rejected cache files when loading detects a build mismatch or invalid metadata.
Useful? React with 👍 / 👎.
1 participant
Seminarly currently requires users to start update downloads manually. This adds opt-in background checks and downloads while keeping installation and restart under user control, and prepares v0.1.15 (build 16).
Validation: the full 507-test local suite and signing identity, runtime packaging, architecture, and update-feed helper tests pass for build 16. Signed installers and public-download verification will be completed before publication.