Skip to content

fix(MemoryGraph): first-wins on duplicate KNOWLEDGE slugs (drop UsageGraphError crash) #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Luo0oo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(MemoryGraph): first-wins on duplicate KNOWLEDGE slugs (drop UsageGraphError crash) #1408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions LifeOS/install/LifeOS/TOOLS/MemoryGraph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,19 @@ function buildGraph(raws: Raw[], layer: EdgeLayer = "declared"): { graph: Graph;

// bare-slug -> id resolver (knowledge slug is bare; work id is "work:slug")
const bareToId = new Map<string, string>();
// Track winner's source path so we can warn on collision (report-generator
// tool, not a scriptable pipe — silent drop hides data loss from users).
const idToPath = new Map<string, string>();
for (const { node } of raws) {
if (graph.hasNode(node.id)) {
// First-wins on duplicate ids (e.g. Companies/synthesis.md and
// Research/synthesis.md both derive slug "synthesis"). Matches the
// bareToId first-wins semantics below.
console.warn(`[MemoryGraph] slug collision: kept ${idToPath.get(node.id)}, skipped ${node.path}`);
continue;
}
graph.addNode(node.id, { ...node });
idToPath.set(node.id, node.path);
const bare = node.id.startsWith("work:") ? node.id.slice(5) : node.id;
if (!bareToId.has(bare)) bareToId.set(bare, node.id);
}
Expand Down