Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[1.0.0] - 2026-05-30
Parity-with-the-reference release. Parity with the Python
beat_thisreference is now verified by acommitted golden test (
tests/python_parity.rs), not just argued by construction:F-measure == 1.0 (standard FP32 model) and ≥ 0.99 (small model) at the ±70 ms MIR
window for both beats and downbeats.
Added
tests/python_parity.rs+scripts/gen_golden.py), runnable on a fresh clone with the committed small modeland the remaining known divergence
Changed
deduplicate_peakskeeps fractional merged-peak frame positions instead ofrounding to an integer frame, matching the Python reference (removes a ≤10 ms
divergence on merged adjacent peaks)
beat_countsnow ports the reference'sinfer_beat_numbers: pickup-measure(anacrusis) beats are numbered so they lead into the first downbeat, matching the
Python
.beats/JSON count column (beat/downbeat times are unchanged)ort(ONNX Runtime) backend is now behind an off-by-defaultortCargofeature. The default build is pure-Rust
rtenonly — nolibonnxruntimeneeded.Build/test the ort backend (and its
--runtime ort, cross-runtime parity tests, andop-level
--profile) with--features ort.Notes
rubatosinc vs Pythonsoxr) differssub-perceptually for inputs not already at 22050 Hz; inputs at 22050 Hz resample
exactly. Decode precision (f32 + symphonia vs float64 + torchaudio) differs negligibly.
--dbnpath (madmom DBN) isintentionally not implemented; the model is designed to be accurate without it, and
Python's default is also "minimal", so default-vs-default output matches.
verified by
tests/cross_runtime.rs.