Repository navigation
Reduce dependencies for library use - #13
Merged
Merged
Conversation
Owner
|
Hey! Thanks for the PR ❤️ and sorry for the late reply: I've miss it completely until today 🙏 |
danigb
added a commit
that referenced
this pull request
Oct 2, 2026
Resolve the audio.rs conflict by keeping #13's `decode` submodule and 1.1.0's early `drop(samples)` in `load_audio`. Gate the 1.1.0-only tests (identity_v1_0_0, stream_integration) and the crate-level doc example on `decode`, add a `--no-default-features` clippy/test step to CI, note the new features in the CHANGELOG and date the 1.1.0 entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
while trying out this crate as a dependency, I noticed that it pulls in a lot of dependencies (such as
clap) which are only needed by the CLI. I moved those behind aclifeature. Furthermore I added adecodefeature which gates import functions requiring thesymphoniacrate andserdefor Searialize / Deserialize implementation ofTensorAll features are still enabled by default, so backwards compatibility is kept. But you can now do
for a much reduced dependency footprint.