Skip to content

New Theme OneDark#87

Merged
danipen merged 1 commit into
danipen:masterfrom
ZeoNish:onedark-color-theme
May 20, 2025
Merged

New Theme OneDark#87
danipen merged 1 commit into
danipen:masterfrom
ZeoNish:onedark-color-theme

Conversation

@ZeoNish
Copy link
Copy Markdown
Contributor

@ZeoNish ZeoNish commented May 19, 2025

No description provided.

@danipen
Copy link
Copy Markdown
Owner

danipen commented May 20, 2025

Thanks!

@danipen danipen merged commit 6c5ba38 into danipen:master May 20, 2025
5 checks passed
@ZeoNish
Copy link
Copy Markdown
Contributor Author

ZeoNish commented May 20, 2025

Hey man. Pull all themes?
image

ps. I got a little carried away...

@danipen
Copy link
Copy Markdown
Owner

danipen commented May 20, 2025

I think it's better to include them on demand so the DLL doesn't grow too much. By the way, how big is each theme?

@danipen
Copy link
Copy Markdown
Owner

danipen commented May 20, 2025

Oh, they’re around 6KB each, so if you want, we can include all the new themes. Have you already tested that they work fine?

@ZeoNish
Copy link
Copy Markdown
Contributor Author

ZeoNish commented May 20, 2025

I think it's better to include them on demand so the DLL doesn't grow too much. By the way, how big is each theme?

image

@ZeoNish
Copy link
Copy Markdown
Contributor Author

ZeoNish commented May 20, 2025

image

I can't guarantee 100% that everything will be perfect. But in any case, it will be much easier to fix in the future.

@danipen
Copy link
Copy Markdown
Owner

danipen commented May 20, 2025

Yeah the thing is... If using those new themes doesn't makes AvaloniaEdit to explode we're ok.

@ZeoNish
Copy link
Copy Markdown
Contributor Author

ZeoNish commented May 20, 2025

We just want to use AvaloniaEdit in one of our projects and I decided to contribute to the development.

@ZeoNish
Copy link
Copy Markdown
Contributor Author

ZeoNish commented May 20, 2025

Take a look and decide for yourself if it's right for you.

@ZeoNish
Copy link
Copy Markdown
Contributor Author

ZeoNish commented May 20, 2025

nice
image

need to fix the background color in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants