Repository navigation
Prepare Kin 1.3 signing-only trial - #63
Merged
Merged
Conversation
dannydover
marked this pull request as ready for review
November 9, 2026 01:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Prepare Kin 1.3.0 build 7 and a manually dispatched, approval-gated Kin Dev signing-only trial. Upload mode is rejected and the upload step remains disabled. The existing production signing proposal remains disabled. This draft does not sign, upload, release, or configure credentials; CI uses synthetic fixtures and fake tools.
Review blockers before any real trial
kin-dev-signingenvironment and its main-only, required-reviewer, and no-admin-bypass protections remain configured. The workflow does not currently fail closed if the environment is deleted and auto-created without protections; similarly named higher-scope secrets could fall back. Resolve this before enabling a real trial.xcode-27alone is not proof. Review the distribution key's team-wide signing risk, process-argument password exposure, and cleanup limitations after runner loss or SIGKILL.A protected-environment setup, user-direct secret entry, signed trial, upload/TestFlight distribution, App Review and release each require their own applicable approval. No secret values belong in this PR or logs. Earlier Friend/Save and simulator cleanup failures remain unresolved.
Validation
Local reconstructed suite: 146 script tests passed, including four fake-tool Dev signing/cleanup cases; indexed repository privacy guard, project lint, YAML/shell syntax and patch dry run passed. Hosted credential-free PR CI will run automatically. Real signing and Apple behavior are not established by these tests.