Repository navigation
Keep normal-notebook persistence in required smoke - #65
Merged
Merged
Conversation
dannydover
marked this pull request as ready for review
November 9, 2026 04:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain required UI coverage for a normal notebook launch, direct creation and save of an uncategorized person, the People row and profile, and persistence after cold relaunch. Keep the prior real Friend-toggle journey in the manual broad UI suite and add an explicit Kin Dev 1.3 device QA obligation.
This intentionally removes real Friend-on interaction and persistence from the required smoke gate. Broad UI and lower-layer tests do not replace that required end-to-end coverage; the manual check and production Release/upgrade validation remain necessary. Earlier Friend/Save and simulator-cleanup failures remain visible and unresolved.
Local validation: Swift parsing, 154 script tests, exact four-test smoke selection, repository privacy guard and patch dry run passed. Hosted credential-free PR checks will validate the new journey; no signing or upload is part of this change.