Skip to content

ppc64le: address review comments from mkannwischer#4

Merged
dannytsen merged 1 commit into
dannytsen:new_mainfrom
bhess:bhe-review
May 20, 2026
Merged

ppc64le: address review comments from mkannwischer#4
dannytsen merged 1 commit into
dannytsen:new_mainfrom
bhess:bhe-review

Conversation

@bhess
Copy link
Copy Markdown
Collaborator

@bhess bhess commented May 20, 2026

Addresses the latest review comments from @mkannwischer:
pq-code-package#1648 (review)

  • remove the liboqs integration from this PR; it can come in a follow-up once validated
  • fix the indentation issue
  • add the POWER8_VECTOR guard
  • update the copyright header as suggested
  • add toolchain_ppc64le to cross-autogen
  • extend CI with separate POWER7 and POWER8 coverage
  • re-run autogen in the nix cross-ppc64le environment

@dannytsen, one remaining item is rebasing onto main, as requested here:
pq-code-package#1648 (review)

I do not currently have permission to rebase or merge main into your branch directly. If you want me to take care of that, please grant me write access to the branch. Otherwise, please rebase it when convenient.

Signed-off-by: Basil Hess <bhe@zurich.ibm.com>
@dannytsen
Copy link
Copy Markdown
Owner

@bhess You have the write access now.

@dannytsen dannytsen merged commit a122b2a into dannytsen:new_main May 20, 2026
@bhess
Copy link
Copy Markdown
Collaborator Author

bhess commented May 20, 2026

@bhess You have the write access now.

Thanks, I'll merge main to the branch then and push that directly to new_main.

@dannytsen
Copy link
Copy Markdown
Owner

@bhess You have the write access now.

Thanks, I'll merge main to the branch then and push that directly to new_main.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants