Fix OpenCode leaked think normalization#457
Merged
Merged
Conversation
Preserve leaked OpenCode/Kimi think content as thinking transcript items instead of stripping it from assistant text. Handle balanced tags, malformed leading closer markers, marker-only parts, unterminated open tags, and role-missing OpenCode messages while preserving user-authored text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve leaked OpenCode/Kimi think content as thinking transcript items instead of stripping it from assistant text. Handle balanced tags, malformed leading closer markers, marker-only parts, unterminated open tags, and role-missing OpenCode messages while preserving user-authored text.
Changes:
stripThinkTagswithitemsFromAssistantTextPartthat segments think-tag content into visiblethinkingitemsNormalizedTextSegmenttype,normalizeBalancedThinkTags,segmentsToItemshelpersitemFromPartto returnFreshAgentTranscriptItem[](flatMap) and acceptfollowedByToolparamcomputeToolAfterByPartIndexandtextSummaryFromItemshelpersRebase notes: Resolved conflict in
normalizeOpencodeTurn— kept main's role-less message rejection policy (nullreturn) while applying the think-tag normalization improvements. Updated one branch test to match main's role-less rejection behavior.Kata:
0yza