Open
Conversation
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
This reverts commit 7665d46. Skip-daos-build-and-test: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
grom72
changed the title
Contributor
Author
|
The 'DAOS Build and Test' stage has been cancelled because the changes do not affect the main 'pipeline-lib' functionality. |
osalyk
approved these changes
Mar 13, 2026
phender
requested changes
Mar 13, 2026
| commits = [[pragmas: [''], | ||
| /* groovylint-disable-next-line UnnecessaryGetter */ | ||
| skips: [isPr(), isPr(), false, isPr(), !isPr(), !isPr(), true, !isPr()]], | ||
| skips: [false, false, false, false, false, false, true, false]], |
Contributor
There was a problem hiding this comment.
The isPr() is now no longer used for the Functional VM stages, but it is still used for the HW stages. The reason isPr() is still relevant, is we need the master and release/* branches to run certain Functional test stages when the build is kicked off in a PR, but when the PR is landed, we only run a subset of the tests - i.e. no Functional HW tests.
I have a fix working in https://github.com/daos-stack/pipeline-lib/pull/487/changes if you wan to reference it.
Suggested change
| skips: [false, false, false, false, false, false, true, false]], | |
| skips: [false, false, false, false, !isPr(), !isPr(), true, !isPr()]], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SRE-3534 ci: fix Commit Pragma tests to follow latest changes in
isPr()introduced by #495