Adding support for HttpPipeline #1585
Open
+117
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salaboy
force-pushed
the
1584-middleware
branch
2 times, most recently
from
6c82a33 to
187f29e
Compare
cicoyle
requested changes
Oct 24, 2025
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
CI looks to be all red, mind taking a look and fixing up CI to be green again?
salaboy
force-pushed
the
1584-middleware
branch
from
7e1b673 to
81d5448
Compare
Collaborator
Author
|
@cicoyle checkstyle issue fixed |
Contributor
|
@salaboy the codecov is failing. Can you please take a look ? |
cicoyle
previously approved these changes
Oct 27, 2025
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
Im good with the changes here, but can you add the tests to make codecov pass?
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
* Add statestore example with Outbox pattern Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> * Clean events after each test Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> * Add license header Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> * Apply pull request suggestions Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> --------- Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> Co-authored-by: salaboy <Salaboy@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
* adding new method signature plus test Signed-off-by: salaboy <Salaboy@gmail.com> * re adding imports Signed-off-by: salaboy <Salaboy@gmail.com> * fixing style Signed-off-by: salaboy <Salaboy@gmail.com> * checking empty metadata Signed-off-by: salaboy <Salaboy@gmail.com> * copy meta for safety and check if key is present Signed-off-by: salaboy <Salaboy@gmail.com> * Centralize Maven dependency version management (dapr#1564) Signed-off-by: salaboy <Salaboy@gmail.com> * Fix dependencies multi app build and add proper test deps (dapr#1572) * Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * reverting pom Signed-off-by: salaboy <Salaboy@gmail.com> * fix codestyle Signed-off-by: salaboy <Salaboy@gmail.com> * using metaCopy Signed-off-by: salaboy <Salaboy@gmail.com> --------- Signed-off-by: salaboy <Salaboy@gmail.com> Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: salaboy <Salaboy@gmail.com>
* Add gRPC support to Dapr testcontainer Signed-off-by: wlfgang <wlfgang@westridgesystems.com> * Avoid using null to indicate default value Signed-off-by: wlfgang <wlfgang@westridgesystems.com> --------- Signed-off-by: wlfgang <wlfgang@westridgesystems.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: wlfgang <wlfgang@westridgesystems.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…apr#1589) * example Signed-off-by: Cassandra Coyle <cassie@diagrid.io> * docs for example Signed-off-by: Cassandra Coyle <cassie@diagrid.io> --------- Signed-off-by: Cassandra Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com>
…r#1596) Signed-off-by: salaboy <Salaboy@gmail.com>
* Adding a Flux based subscribeToEvents method Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Simplify GRPC stream handling Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Simplify Javadoc Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix unit tests and simplify implementation Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Adding event subscriber stream observer to simplify subscription logic Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Use start() method to start stream subscription Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Add unit test for event suscriber observer Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Improve the tests a little bit Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Remove the unnecessary method Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Improve error handling and use CloudEvent wrapper Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix unit tests asserts Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Adjust Java examples for Subscriber Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
* Remove SDK docs due to migration to main Docs repo Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com> * Remove sed lines related to sdk docs Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com> --------- Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com> Co-authored-by: salaboy <Salaboy@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
…r#1575) * fixing checkstyle and javadocs Signed-off-by: salaboy <Salaboy@gmail.com> * Replace openjdk:17-jdk-slim to eclipse-temurin:17-jdk-jammy (dapr#1574) Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * Align Java API with other languages (dapr#1560) * Align Java API with other languages Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> * Update documentation Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> * Change return type of waitForWorkflowStart method Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * use built in durable task Signed-off-by: salaboy <Salaboy@gmail.com> * exclude jacoco rules for examples and durabletask-client Signed-off-by: salaboy <Salaboy@gmail.com> * increasing timeout for IT Signed-off-by: salaboy <Salaboy@gmail.com> * removing dt build from matrix Signed-off-by: salaboy <Salaboy@gmail.com> * adding java to dt build Signed-off-by: salaboy <Salaboy@gmail.com> * Fix dependencies multi app build and add proper test deps (dapr#1572) * Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * docs: add architecture diagram to README (dapr#1549) * Preview New README * Preview New README 2 * Preview New README 3 * docs: add architecture diagram showing Java SDK interaction with Dapr runtime (close #<915>) * docs: add architecture diagram showing Java SDK interaction with Dapr runtime CORRECTION (close #<915>) * docs: add architecture diagram showing Java SDK interaction with Dapr runtime (close #<915>) * docs: add architecture diagram showing Java SDK interaction with Dapr runtime (close #<915>) --------- Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * Add statestore example with Outbox pattern (dapr#1582) * Add statestore example with Outbox pattern Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> * Clean events after each test Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> * Add license header Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> * Apply pull request suggestions Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> --------- Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> Co-authored-by: salaboy <Salaboy@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * adding new method signature plus test (dapr#1570) * adding new method signature plus test Signed-off-by: salaboy <Salaboy@gmail.com> * re adding imports Signed-off-by: salaboy <Salaboy@gmail.com> * fixing style Signed-off-by: salaboy <Salaboy@gmail.com> * checking empty metadata Signed-off-by: salaboy <Salaboy@gmail.com> * copy meta for safety and check if key is present Signed-off-by: salaboy <Salaboy@gmail.com> * Centralize Maven dependency version management (dapr#1564) Signed-off-by: salaboy <Salaboy@gmail.com> * Fix dependencies multi app build and add proper test deps (dapr#1572) * Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * reverting pom Signed-off-by: salaboy <Salaboy@gmail.com> * fix codestyle Signed-off-by: salaboy <Salaboy@gmail.com> * using metaCopy Signed-off-by: salaboy <Salaboy@gmail.com> --------- Signed-off-by: salaboy <Salaboy@gmail.com> Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * Bump actions/upload-artifact from 4 to 5 (dapr#1587) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: salaboy <Salaboy@gmail.com> * Add gRPC support to Dapr testcontainer (dapr#1586) * Add gRPC support to Dapr testcontainer Signed-off-by: wlfgang <wlfgang@westridgesystems.com> * Avoid using null to indicate default value Signed-off-by: wlfgang <wlfgang@westridgesystems.com> --------- Signed-off-by: wlfgang <wlfgang@westridgesystems.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: wlfgang <wlfgang@westridgesystems.com> Signed-off-by: salaboy <Salaboy@gmail.com> * Use dependencies BOM and remove duplicates. (dapr#1588) Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * Examples + Docs for App API Token authentication for gRPC and HTTP (dapr#1589) * example Signed-off-by: Cassandra Coyle <cassie@diagrid.io> * docs for example Signed-off-by: Cassandra Coyle <cassie@diagrid.io> --------- Signed-off-by: Cassandra Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com> * Another set of Maven version, properties and plugin improvements (dapr#1596) Signed-off-by: salaboy <Salaboy@gmail.com> * Adding a Flux based subscribeToEvents method (dapr#1598) * Adding a Flux based subscribeToEvents method Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Simplify GRPC stream handling Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Simplify Javadoc Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix unit tests and simplify implementation Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Adding event subscriber stream observer to simplify subscription logic Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Use start() method to start stream subscription Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Add unit test for event suscriber observer Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Improve the tests a little bit Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Remove the unnecessary method Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Improve error handling and use CloudEvent wrapper Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix unit tests asserts Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Adjust Java examples for Subscriber Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * Remove SDK docs due to migration to main Docs repo (dapr#1593) * Remove SDK docs due to migration to main Docs repo Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com> * Remove sed lines related to sdk docs Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com> --------- Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com> Co-authored-by: salaboy <Salaboy@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * cleaning up sdk version script Signed-off-by: salaboy <Salaboy@gmail.com> --------- Signed-off-by: salaboy <Salaboy@gmail.com> Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: wlfgang <wlfgang@westridgesystems.com> Signed-off-by: Cassandra Coyle <cassie@diagrid.io> Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com> Co-authored-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Raymundo Zamora <raymundo.zamora@encora.com> Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com> Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: wlfgang <14792753+wlfgang@users.noreply.github.com> Co-authored-by: wlfgang <wlfgang@westridgesystems.com> Co-authored-by: Marc Duiker <marcduiker@users.noreply.github.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.5.1 to 5.5.2. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5.5.1...v5.5.2) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: 5.5.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: salaboy <Salaboy@gmail.com>
* Create Dapr WaitStrategy to improve ITs ergonomics Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Improve unit tests naming and coverage Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix a potential NPE and remove extra "for..." methods for pubsub and topic. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE properly for actor match Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix NPE another potential NPEs. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Rename to use wait strategy to use abstract prefix. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Add more tests to cover null checks Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Fix pubsub outbox IT. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Ignore pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> * Disable pubsub outbox for now. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v6) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
force-pushed
the
1584-middleware
branch
from
0bf6a67 to
fcc8da5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1585 +/- ##
============================================
+ Coverage 76.91% 78.79% +1.87%
- Complexity 1592 2041 +449
============================================
Files 145 226 +81
Lines 4843 6130 +1287
Branches 562 671 +109
============================================
+ Hits 3725 4830 +1105
- Misses 821 960 +139
- Partials 297 340 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@dapr/maintainers-java-sdk all working ready for re-review |
cicoyle
requested changes
Jan 5, 2026
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
diff lgtm, but the history is showing a lot more commits than it should - can you clean up the history to just show your added commits from adding the logic in the PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for HttpPipeline to DaprContainer
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1584
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: