Dev #57
Open
Dev #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains implementation of base logic for movie application.
Some concepts implement only partially. App use single activity application paradigm, because on current moment it is small. MVVM pattern for presentation layer. Koin for dependencies injection, because project looking simple. For navigation, use Android Navigation Component. Set up three variant for configuration of different logic and environment for development process.
Added leakcanary for tracing memory leaks, set up logging for retrofit calls. Also I prefer to use stetho. Added some tests to cover business logic, in ideal it has to cover all viewModels, use cases, mappers and other classes that contain business logic. Not implemented yet, but I will do next: set up CI/CD for productive work with a team. I will use Bitrise or Github action for run test on PR, for build test application, for delivery QA, for publication I google play or other stores. Also, I will configure App Distribution and Firebase crashlytics.
I will be glad to get review and feedback about my code.
Happy codding!
MovieUp_demo.webm