Feature: resolve rs/@wikiData against LOBID#34
Open
skurzinz wants to merge 2 commits intodariok:masterfrom
Open
Feature: resolve rs/@wikiData against LOBID#34skurzinz wants to merge 2 commits intodariok:masterfrom
rs/@wikiData against LOBID#34skurzinz wants to merge 2 commits intodariok:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently implemented as a separate stylesheet to be run in an additional Oxygen scenario/step or saxon run.
If deemed useful it may make sense to include this in an additional parameter.
The current output of
page2teifor documents that have Transkribus generated Wikidata IDs is not TEI-valid (tei:rs/@wikiData). My suggestion would be to create astandOffwith all necessarylistXXXand point to them as I did in https://github.com/skurzinz/page2tei/blob/e5459ce3b08b35ffc56c66b946d08611defe067e/resolve-wikiData-lobid.xsl#L120. Checking LOBID for alternative reference/authority file identifiers should then be made optional depending on a parameter.@dariok so far I did not provide any tests. Would it help to just provide the contents of mets and page for a sample document, or should I invite you to the collection I took my sample from?