Skip to content

[Dev Feature] Method signature scanning to handle InvalidNativeSignature exceptions. #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
do-gamer wants to merge 1 commit into from
Closed

[Dev Feature] Method signature scanning to handle InvalidNativeSignature exceptions. #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/main/java/com/github/manolo8/darkbot/core/api/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import com.github.manolo8.darkbot.utils.MathUtils;

import java.util.Set;
import java.util.concurrent.CompletableFuture;

public class Utils {
public static final String SELECT_MAP_ASSET = "MapAssetNotificationTRY_TO_SELECT_MAPASSET";
Expand Down Expand Up @@ -98,6 +99,31 @@ else if (ret == 0) {

return true;
}

default CompletableFuture<Void> scanMethodSignature(boolean checkName, String signature, int index, long object) {
return CompletableFuture.runAsync(() -> {
if (!ByteUtils.isValidPtr(object)) {
System.out.println("[SignatureScan] invalid object for signature: " + signature);
return;
}

int scanWindow = 20;
int fromIndex = Math.max(0, index - scanWindow);
int toIndex = index + scanWindow;

boolean found = false;
for (int idx = fromIndex; idx <= toIndex; idx++) {
int result = checkMethodSignature(object, idx, checkName, signature);
if (result == 1) {
found = true;
System.out.println("[SignatureScan] match at index " + idx + ": " + signature);
}
}
if (!found) {
System.out.println("[SignatureScan] no match in range " + fromIndex + ".." + toIndex + ": " + signature);
}
});
}
}

}
10 changes: 8 additions & 2 deletions src/main/java/com/github/manolo8/darkbot/core/api/adapters/KekkaPlayerAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import com.github.manolo8.darkbot.core.BotInstaller;
import com.github.manolo8.darkbot.core.api.Capability;
import com.github.manolo8.darkbot.core.api.GameAPIImpl;
import com.github.manolo8.darkbot.core.api.InvalidNativeSignature;
import com.github.manolo8.darkbot.core.api.Utils;
import com.github.manolo8.darkbot.core.entities.Box;
import com.github.manolo8.darkbot.core.entities.Entity;
Expand Down Expand Up @@ -159,8 +160,13 @@ public void setMaxFps(int maxFps) {

@Override
public boolean callMethodChecked(boolean checkName, String signature, int index, long... arguments) {
if (checkSignature(checkName, signature, index, arguments[0]))
return callMethodAsync(index, arguments);
try {
if (checkSignature(checkName, signature, index, arguments[0]))
return callMethodAsync(index, arguments);
} catch (InvalidNativeSignature e) {
scanMethodSignature(checkName, signature, index, arguments[0]);
throw e;
}

return false;
}
Expand Down
12 changes: 9 additions & 3 deletions src/main/java/com/github/manolo8/darkbot/core/api/adapters/TanosAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import com.github.manolo8.darkbot.core.BotInstaller;
import com.github.manolo8.darkbot.core.api.Capability;
import com.github.manolo8.darkbot.core.api.GameAPIImpl;
import com.github.manolo8.darkbot.core.api.InvalidNativeSignature;
import com.github.manolo8.darkbot.core.api.Utils;
import com.github.manolo8.darkbot.core.entities.Box;
import com.github.manolo8.darkbot.core.entities.Entity;
Expand Down Expand Up @@ -79,9 +80,14 @@ public Set<String> signatureCache() {

@Override
public boolean callMethodChecked(boolean checkName, String signature, int index, long... arguments) {
if (checkSignature(checkName, signature, index, arguments[0])) {
callMethod(index, arguments);
return true;
try {
if (checkSignature(checkName, signature, index, arguments[0])) {
callMethod(index, arguments);
return true;
}
} catch (InvalidNativeSignature e) {
scanMethodSignature(checkName, signature, index, arguments[0]);
throw e;
}
return false;
}
Expand Down
Loading