Fix incorrect NPC map list registration during transitions#456
Open
dm94 wants to merge 3 commits into
Open
Conversation
dm94
commented
May 7, 2026
dm94
commented
Contributor
- Reordered entity update and map switch in MapManager to prevent old entities from being associated with new map IDs.
- Added validation in ConfigEntity to ensure only positive map IDs are added to NpcInfo mapList.
- Reordered entity update and map switch in MapManager to prevent old entities from being associated with new map IDs. - Added validation in ConfigEntity to ensure only positive map IDs are added to NpcInfo mapList. Co-authored-by: dm94 <7419213+dm94@users.noreply.github.com>
- Moved mapManager.tick() before hero.tick() in Main.java to ensure map ID is updated before hero/pet processing. - Added entities.clear() before switchMap in MapManager.update to purge stale entities during transitions. - Added mapId > 0 validation in ConfigEntity when adding to NpcInfo mapList to prevent invalid map IDs from being recorded. Co-authored-by: dm94 <7419213+dm94@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.