feat(config builder): add support for inherited config fields#458
Draft
dm94 wants to merge 1 commit into
Draft
Conversation
add support for configuration fields declared in superclasses, which were previously ignored by the config builder. clean up code across the file: - remove unused java.util.Arrays and java.util.stream.Collectors imports - fix inconsistent indentation throughout ConfigBuilder.java - refactor the participates helper method to accept an allOptions parameter - rewrite the getChildren method to loop over the full class hierarchy instead of using streams - add support for per-class Configuration annotations to set parent key and allOptions flag per class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for configuration fields declared in superclasses, which were previously ignored by the config builder.
clean up code across the file: