Skip to content

Cas/monaco diffs#62

Open
Cas Linden (CasLinden) wants to merge 15 commits intodevelopfrom
cas/monaco-diffs
Open

Cas/monaco diffs#62
Cas Linden (CasLinden) wants to merge 15 commits intodevelopfrom
cas/monaco-diffs

Conversation

@CasLinden
Copy link
Copy Markdown
Contributor

@CasLinden Cas Linden (CasLinden) commented Apr 30, 2026

Summary

Replace kibo ui codeblocks for diff display with monaco editor diffs, showing accurate file states and line numbers.
Adds scroll to hunk feature
Adds styles and configuration for monaco editor

Edit 05/05

  • fix monaco editor state resets, for diffs and nix-editor
  • use non-diff editor for one-version deleted or untracked files
  • add color theme extracted from claude design tests
  • remove edit button from deleted type diffs
  • improved UX and styling in general

Test Plan

Make more changes in a file and go to the diff tab, open the diff.

Edit 05/05

  • edited stories, added mocks and improved testability
Suite Total Pass Fail Skip Δ
Vitest unit 10 files (75 tests) 9 1 unchanged
Vitest storybook 47 files (153 tests) 45 2 only rebuild-overlay-panel's Starting and Infinite Recursion Error, both develop-side)
Rust unit 38 modules 38 0 unchanged
Playwright E2E 2 2 0 unchanged
wdio 6 suites 4 2 unchanged (conversational + onboarding; not branch-related)

Docs

  • No docs update needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Warnings
⚠️ Please assign this PR to someone (usually yourself).
⚠️ ❗ Big PR (2769 lines changed). Consider splitting it into smaller, focused changes.
⚠️

New TypeScript source files were added without any new tests:

  • apps/native/src/components/widget/summaries/monaco-setup.ts
  • apps/native/src/components/widget/summaries/monaco-theme.ts

📋 PR Overview

Lines changed 2769 (+1422 / -1347)
Files 20 added, 30 modified, 6 deleted
Draft / WIP no
Has Test Plan yes
New UI components yes (6)
New Storybook stories yes (6)
New Rust modules no
New TS source files yes (8)
New tests no
package.json touched yes
Cargo.toml touched no
Infra / CI touched no

Generated by 🚫 dangerJS against 8a59905

Base automatically changed from main to develop May 4, 2026 09:33
@CasLinden Cas Linden (CasLinden) marked this pull request as ready for review May 8, 2026 12:27
@CasLinden Cas Linden (CasLinden) marked this pull request as draft May 8, 2026 12:30
@CasLinden Cas Linden (CasLinden) marked this pull request as ready for review May 8, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants