update azure resource names to match CAF resource abbreviations#1
Open
clowa wants to merge 2 commits into
Open
update azure resource names to match CAF resource abbreviations#1clowa wants to merge 2 commits into
clowa wants to merge 2 commits into
Conversation
Author
|
Hi @mstratford-dt, just want to reach of if you see any value in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to resource suffixes to match the suggested resource abbreviations of the Azure Cloud Adoption Framework. This could be beneficial for this module since most of the customers follow these recommendations to have a consistent naming.
Compliance with Naming Conventions:
bastion.tf: Adjusted the names of the bastion host and bastion public IP resources.(
azurerm_public_ip.bastion_public_ip,azurerm_bastion_host.bastion)locals.tf: Adjusted the names of the load balancer and data collection rule.(
local.lb_name,local.data_collection_name)logging.tf: Adjusted the data collection rule and its association names as well as the log analytics workspace.(
azurerm_monitor_data_collection_rule.vsensor_data_collection,azurerm_monitor_data_collection_rule_association.vsensor_data_collection_assoc,azurerm_log_analytics_workspace.vsensor_logs)network.tf: Adjusted the names of the NAT gateway and NAT gateway public IP resources.(
azurerm_public_ip.natgw_public_ip,azurerm_nat_gateway.natgw)pcaps.tf: Adjusted the name of the service endpoint policy resource.(
azurerm_subnet_service_endpoint_storage_policy.pcaps_service_endpoint_policy)private_link.tf: Adjusted the name of the private link service resource. (azurerm_private_link_service.ossensor_private_link)Minor Cleanups:
main.tf: Simplified the azurerm_subscription data block.(
data.azurerm_subscription.subscription)pcaps.tf: Simplified the random_uuid resource block.(
random_uuid.pcap_uuid)