Skip to content

fix(install): resolve custom install failures and missing agent-metadata #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darrenhinde wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(install): resolve custom install failures and missing agent-metadata #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d17eb13
fix(install): resolve custom install failures and missing agent-metad…
darrenhinde Mar 25, 2026
9d935b3
fix(install): correct root-path routing, display counter, and duplica…
darrenhinde Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 45 additions & 25 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ INSTALL_DIR="${OPENCODE_INSTALL_DIR:-.opencode}" # Allow override via environme
TEMP_DIR="/tmp/opencode-installer-$$"

# Cleanup temp directory on exit (success or failure)
trap 'rm -rf "$TEMP_DIR" 2>/dev/null || true' EXIT INT TERM
trap 'rm -rf "$TEMP_DIR" 2>/dev/null || true' EXIT

# Global variables
SELECTED_COMPONENTS=()
Expand Down Expand Up @@ -297,13 +297,20 @@ get_profile_components() {
get_component_info() {
local component_id=$1
local component_type=$2

local registry_key
registry_key=$(get_registry_key "$component_type")

if [ "$component_type" = "context" ] && [[ "$component_id" == */* ]]; then
jq_exec "first(.components.contexts[]? | select(.path == \".opencode/context/${component_id}.md\"))" "$TEMP_DIR/registry.json"
local result
result=$(jq_exec "first(.components.contexts[]? | select(.path == \".opencode/context/${component_id}.md\"))" "$TEMP_DIR/registry.json")
if [ -z "$result" ] || [ "$result" = "null" ]; then
result=$(jq_exec "first(.components.contexts[]? | select(.path == \".opencode/context/${component_id}\"))" "$TEMP_DIR/registry.json")
fi
echo "$result"
return
fi

jq_exec ".components.${component_type}[]? | select(.id == \"${component_id}\" or (.aliases // [] | index(\"${component_id}\")))" "$TEMP_DIR/registry.json"
jq_exec ".components.${registry_key}[]? | select(.id == \"${component_id}\" or (.aliases // [] | index(\"${component_id}\")))" "$TEMP_DIR/registry.json"
}

resolve_component_path() {
Expand Down Expand Up @@ -344,8 +351,12 @@ get_install_path() {
local registry_path=$1
# Strip leading .opencode/ if present
local relative_path="${registry_path#.opencode/}"
# Return INSTALL_DIR + relative path
echo "${INSTALL_DIR}/${relative_path}"
# If path didn't start with .opencode/, it's a root-relative path (e.g. env.example, README.md)
if [ "$relative_path" = "$registry_path" ]; then
echo "./${registry_path}"
else
echo "${INSTALL_DIR}/${relative_path}"
fi
}

expand_context_wildcard() {
Expand Down Expand Up @@ -554,9 +565,7 @@ show_install_location_menu() {
fi

local normalized_path
normalized_path=$(normalize_and_validate_path "$custom_path")

if ! normalize_and_validate_path "$custom_path" > /dev/null; then
if ! normalized_path=$(normalize_and_validate_path "$custom_path"); then
print_error "Invalid path"
sleep 2
show_install_location_menu
Expand Down Expand Up @@ -753,6 +762,9 @@ show_custom_menu() {
read -r -p "Enter category numbers (space-separated) or option: " -a selections

for sel in "${selections[@]}"; do
if [[ ! "$sel" =~ ^[0-9]+$ ]]; then
continue
fi
if [ "$sel" -eq $((${#categories[@]}+1)) ]; then
selected_categories=("${categories[@]}")
break
Expand Down Expand Up @@ -786,15 +798,14 @@ show_component_selection() {
local all_components=()
local component_details=()

local idx=1
for category in "${categories[@]}"; do
local cat_display
cat_display=$(echo "$category" | awk '{print toupper(substr($0,1,1)) tolower(substr($0,2))}')
echo -e "${CYAN}${BOLD}${cat_display}:${NC}"

local components
components=$(jq_exec ".components.${category}[]? | .id" "$TEMP_DIR/registry.json")

local idx=1
while IFS= read -r comp_id; do
local comp_name
comp_name=$(jq_exec ".components.${category}[]? | select(.id == \"${comp_id}\") | .name" "$TEMP_DIR/registry.json")
Expand All @@ -804,7 +815,19 @@ show_component_selection() {
echo " ${idx}) ${comp_name}"
echo " ${comp_desc}"

all_components+=("${category}:${comp_id}")
local singular_type
case "$category" in
agents) singular_type="agent" ;;
subagents) singular_type="subagent" ;;
commands) singular_type="command" ;;
tools) singular_type="tool" ;;
plugins) singular_type="plugin" ;;
skills) singular_type="skill" ;;
contexts) singular_type="context" ;;
config) singular_type="config" ;;
*) singular_type="${category%s}" ;;
esac
all_components+=("${singular_type}:${comp_id}")
component_details+=("${comp_name}|${comp_desc}")

idx=$((idx+1))
Expand All @@ -822,7 +845,7 @@ show_component_selection() {
break
elif [ "$sel" = "done" ]; then
break
elif [ "$sel" -ge 1 ] && [ "$sel" -le ${#all_components[@]} ]; then
elif [[ "$sel" =~ ^[0-9]+$ ]] && [ "$sel" -ge 1 ] && [ "$sel" -le ${#all_components[@]} ]; then
SELECTED_COMPONENTS+=("${all_components[$((sel-1))]}")
fi
done
Expand Down Expand Up @@ -1023,11 +1046,9 @@ perform_installation() {
for comp in "${SELECTED_COMPONENTS[@]}"; do
local type="${comp%%:*}"
local id="${comp##*:}"
local registry_key
registry_key=$(get_registry_key "$type")
local path
path=$(resolve_component_path "$type" "$id")

if [ -n "$path" ] && [ "$path" != "null" ]; then
local install_path
install_path=$(get_install_path "$path")
Expand Down Expand Up @@ -1097,13 +1118,13 @@ perform_installation() {
local type="${comp%%:*}"
local id="${comp##*:}"

# Get the correct registry key (handles singular/plural)
local registry_key
registry_key=$(get_registry_key "$type")

# Get component path
# Get component path (registry key resolved internally)
local path
path=$(resolve_component_path "$type" "$id")

# Registry key needed for multi-file (skills) lookup
local registry_key
registry_key=$(get_registry_key "$type")

if [ -z "$path" ] || [ "$path" = "null" ]; then
print_warning "Could not find path for ${comp}"
Expand Down Expand Up @@ -1288,7 +1309,7 @@ list_components() {

echo -e "${BOLD}Available Components${NC}\n"

local categories=("agents" "subagents" "commands" "tools" "plugins" "skills" "contexts")
local categories=("agents" "subagents" "commands" "tools" "plugins" "skills" "contexts" "config")

for category in "${categories[@]}"; do
local cat_display
Expand Down Expand Up @@ -1443,8 +1464,7 @@ main() {
# Apply custom install directory if specified (CLI arg overrides env var)
if [ -n "$CUSTOM_INSTALL_DIR" ]; then
local normalized_path
if normalize_and_validate_path "$CUSTOM_INSTALL_DIR" > /dev/null; then
normalized_path=$(normalize_and_validate_path "$CUSTOM_INSTALL_DIR")
if normalized_path=$(normalize_and_validate_path "$CUSTOM_INSTALL_DIR"); then
INSTALL_DIR="$normalized_path"
if ! validate_install_path "$INSTALL_DIR"; then
print_warning "Installation path may have issues, but continuing..."
Expand Down
Loading
Loading