Repository navigation
Migrate to ecosystem's health publish check and setup-dart's publish workflow. - #5254
Conversation
|
Uhh I will verify that it actually fixes CI before adding a reviewer again, sorry about that. |
natebosch
left a comment
There was a problem hiding this comment.
Some feedback gemini found while I was working on dart-lang/test#2812 and had it compare to this PR.
| directory="${TAG%-v*}" | ||
| if [[ ! "$directory" =~ ^[a-z_]+$ ]]; then | ||
| echo "No package directory in tag $TAG." | ||
| exit 1 | ||
| fi | ||
| echo "directory=$directory" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Not all publishable packages in this repo live at the top level — packages under builder_pkgs/ (build_web_compilers, mockito, scratch_space) and built_types/ (built_collection, built_value, built_value_generator, built_value_test) will need their parent directory prefix mapped here.
| id-token: write | ||
| pull-requests: write | ||
| attestations: write | ||
| contents: read | ||
| uses: dart-lang/setup-dart/.github/workflows/publish.yml@a2a85876fe519099fd3f528670216b240f975906 |
There was a problem hiding this comment.
a2a85876fe519099fd3f528670216b240f975906 is from the unmerged draft PR dart-lang/setup-dart#199, which passes --with-attestation to dart pub publish on stable Dart (not supported yet, so publishing will fail). Pinning to setup-dart main (a5bff6576dfc51b47eb77d4b7084bba6a4daf8d2, merged in dart-lang/setup-dart#203) uses the reviewed workflow without attestations and only needs id-token: write.
| with: | ||
| working-directory: ${{ needs.package.outputs.directory }} |
There was a problem hiding this comment.
Once pinned to setup-dart main, pass use-flutter: false here too — use-flutter defaults to true on main (dart-lang/setup-dart#203), which would install Flutter and shadow the Dart SDK from setup-dart.
|
Thanks! All three are fixed in f16d4d6, "Address review comments.":
Since then I merged master in, 0ad1155, to pick up the ecosystem pin bump in health.yaml and post_summaries.yaml. |
Fix CI :)