Include evaluation errors in UnresolvedAnnotationException#807
Merged
Conversation
natebosch
reviewed
Mar 11, 2026
natebosch
left a comment
natebosch
left a comment
Member
There was a problem hiding this comment.
We should not be landing arbitrary unrelated changes that AI agents happen to make unprompted in the repo...
Member
Author
|
@natebosch - the dep bumps were just from |
Member
Author
these were done by ME! Using tighten to make sure we don't fall back to versions of packages that aren't resolvable. |
Needed to use newer build features which crash in older SDKs Also bump two other deps using `tighten`
Member
Author
|
Will land #808 first so the diff is more clear |
kevmoo
force-pushed
the
b489415807_crash_better_error
branch
from
March 12, 2026 18:24
f9b019d to
c99975e
Compare
- Extracts `constantEvaluationErrors` from the analyzer's `ElementAnnotation`. - Updates `UnresolvedAnnotationException` to display underlying constant evaluation errors, making it easier to diagnose invalid constants in annotations (e.g., using a `final` variable instead of a `const` variable in an annotation). - Bumps version to 4.2.1. - Tiny bump to dependencies
kevmoo
force-pushed
the
b489415807_crash_better_error
branch
from
March 12, 2026 18:25
c99975e to
21797d2
Compare
Member
Author
|
PTAL @natebosch |
natebosch
approved these changes
Mar 13, 2026
Member
Author
|
@natebosch – can you look at 808 first? Going to land that before this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
constantEvaluationErrorsfrom the analyzer'sElementAnnotation.UnresolvedAnnotationExceptionto display underlying constant evaluation errors, making it easier to diagnose invalid constants in annotations (e.g., using afinalvariable instead of aconstvariable in an annotation).