Skip to content

[yaml] Use correct license in new test - #2597

Merged
liamappelbe merged 1 commit into
mainfrom
yaml_test_license
Sep 15, 2026
Merged

liamappelbe merged 1 commit into
mainfrom
yaml_test_license

Conversation

@liamappelbe

Copy link
Copy Markdown
Contributor

Follow up from #2551

pkgs/yaml/test/error_listener_test.dart is using the wrong license. The yaml package is using an MIT-style license, not a BSD-style. This is causing problems when trying to roll into g3, which has pretty strict license checks.

@liamappelbe
liamappelbe requested a review from a team as a code owner September 15, 2026 03:23

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the copyright and license header in pkgs/yaml/test/error_listener_test.dart to transition from a BSD-style license to an MIT-style license, updating the copyright years and adding Kirill Simonov. There are no review comments, so I have no feedback to provide.

@github-actions

Copy link
Copy Markdown

Package publishing

If you have publishing permissions, you can use the links below to publish the changes after merging this PR.

Package Version Status Publish tag (post-merge)
package:pubspec_parse 1.6.1 ready to publish pubspec_parse-v1.6.1
package:test_reflective_loader 0.6.0 ready to publish test_reflective_loader-v0.6.0
package:yaml ⭐ 3.2.0-wip WIP (no publish necessary)
  • 21 already published.
  • 18 WIP (no publish necessary).

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions

Copy link
Copy Markdown

PR Health

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/html/test/differential_test.dart
pkgs/html/test/dom_parsing_test.dart
pkgs/html/test/mxss_test.dart
pkgs/html/test/noah_ark_clause_limit_test.dart

This check can be disabled by tagging the PR with skip-license-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
yaml Non-Breaking 3.1.4 3.2.0-wip 3.2.0-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
yaml ScalarEvent yaml_node.dart::YamlScalar::internal::scalar
yaml EventType event.dart::Event::type
event.dart::EventType::streamStart
event.dart::EventType::streamEnd
event.dart::EventType::documentStart
event.dart::EventType::documentEnd
event.dart::EventType::alias
event.dart::EventType::scalar
event.dart::EventType::sequenceStart
event.dart::EventType::sequenceEnd
event.dart::EventType::mappingStart
event.dart::EventType::mappingEnd
event.dart::EventType::values
event.dart::Event::new::type
event.dart::ScalarEvent::type

This check can be disabled by tagging the PR with skip-leaking-check.

Unused Dependencies ✔️
Package Status
yaml ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

@liamappelbe
liamappelbe merged commit d22cfa5 into main Sep 15, 2026
22 checks passed
@liamappelbe
liamappelbe deleted the yaml_test_license branch September 15, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants