Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkgs/cli_util/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ linter:
- avoid_bool_literals_in_conditional_expressions
- avoid_classes_with_only_static_members
- avoid_private_typedef_functions
- avoid_redundant_argument_values
- avoid_returning_this
- avoid_unused_constructor_parameters
- avoid_void_async
Expand Down
4 changes: 2 additions & 2 deletions pkgs/cli_util/lib/src/components/select_dialog.dart
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ Future<Set<int>?> _runDialog(
// Handle Ctrl+C and abort the dialog.
final sigintSub = ProcessSignal.sigint.watch().listen((_) {
if (!doneCompleter.isCompleted) {
doneCompleter.complete(null);

@lrhn lrhn Oct 25, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the null.

I want (eventually) to make the parameter not be optional. It's bad API that you can always omit an argument, but it's a runtime error if the type parameter isn't nullable.

doneCompleter.complete();
}
});
cleanupTasks.add(sigintSub.cancel);
Expand Down Expand Up @@ -236,7 +236,7 @@ Future<Set<int>?> _runDialog(
doneCompleter.complete(selectedIndices);
return;
case Key.quit:
doneCompleter.complete(null);
doneCompleter.complete();
return;
}

Expand Down
4 changes: 2 additions & 2 deletions pkgs/cli_util/test/select_dialog_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ ${maybeLegend()}''');
final future = renderer(
['a', 'b', 'c', 'd', 'e', 'f', 'g'],
inputController.stream,
maxVisibleItems: 5, // ignore: avoid_redundant_argument_values
maxVisibleItems: 5,
);
await pumpEventQueue();

Expand Down Expand Up @@ -335,7 +335,7 @@ ${maybeLegend()}''');
final future = renderer(
options,
inputController.stream,
maxVisibleItems: 5, // ignore: avoid_redundant_argument_values
maxVisibleItems: 5,
);
await pumpEventQueue();

Expand Down
2 changes: 2 additions & 0 deletions pkgs/process/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## 5.0.7-wip

## 5.0.6

* Add an example app.
Expand Down
2 changes: 2 additions & 0 deletions pkgs/process/lib/src/interface/common.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// ignore_for_file: deprecated_member_use

import 'package:file/file.dart';
import 'package:file/local.dart';
import 'package:path/path.dart' show Context;
Expand Down
2 changes: 1 addition & 1 deletion pkgs/process/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: process
description: A pluggable, mockable process invocation abstraction for Dart.
version: 5.0.6
version: 5.0.7-wip
repository: https://github.com/dart-lang/tools/tree/main/pkgs/process
issue_tracker: https://github.com/dart-lang/tools/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Aprocess

Expand Down
2 changes: 2 additions & 0 deletions pkgs/process/test/src/interface/common_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// ignore_for_file: deprecated_member_use

import 'dart:io' as io;

import 'package:file/file.dart';
Expand Down
Loading