Repository navigation
[csslib] Serialize partial Font styles as valid CSS #2847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kevmoo
merged 5 commits into
dart-lang:main
from
palmoni5:csslib/font-css-serialization
Nov 16, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0a4cc46
[csslib] Serialize partial Font styles as valid CSS
palmoni5 3b747d6
Keep only this change's changelog entry
palmoni5 0e97e5d
Serialize the font style and variant
palmoni5 7826b98
Address review feedback
palmoni5 ebd02de
Merge remote-tracking branch 'origin/main' into land-2847
kevmoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| // Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| import 'package:csslib/parser.dart'; | ||
| import 'package:test/test.dart'; | ||
|
|
||
| void main() { | ||
| test('font CSS omits null and empty family lists', () { | ||
| expect(const Font(size: 16).cssExpression, '16px'); | ||
| expect(const Font(size: 16, family: []).cssExpression, '16px'); | ||
| expect( | ||
| const Font(size: 16, weight: FontWeight.bold).cssExpression, | ||
| '700 16px', | ||
| ); | ||
| }); | ||
|
|
||
| test('font CSS serializes multiple named families', () { | ||
| expect( | ||
| const Font(size: 16, family: ['Alef', 'serif']).cssExpression, | ||
| '16px Alef, serif', | ||
| ); | ||
| }); | ||
|
|
||
| test('line height is retained without explicit font weight', () { | ||
| const font = Font( | ||
| size: 16, | ||
| lineHeight: LineHeight(24), | ||
| family: ['Alef'], | ||
| ); | ||
| expect(font.cssExpression, '16px/24px Alef'); | ||
| const withoutFamily = Font(size: 16, lineHeight: LineHeight(24)); | ||
| expect(withoutFamily.cssExpression, '16px/24px'); | ||
| }); | ||
|
|
||
| test('font CSS keeps weight and explicit line height', () { | ||
| const font = Font( | ||
| size: 16, | ||
| weight: FontWeight.bold, | ||
| lineHeight: LineHeight(24), | ||
| family: ['Alef'], | ||
| ); | ||
| expect(font.cssExpression, '700 16px/24px Alef'); | ||
| }); | ||
|
|
||
| test('unitless line height stays a multiplier', () { | ||
| const font = Font( | ||
| size: 16, | ||
| lineHeight: LineHeight(1.5, inPixels: false), | ||
| family: ['Alef'], | ||
| ); | ||
| expect(font.cssExpression, '16px/1.5 Alef'); | ||
| }); | ||
|
|
||
| test('font CSS omits a missing size', () { | ||
| expect(const Font(weight: FontWeight.bold).cssExpression, '700'); | ||
| expect(const Font(family: ['Alef']).cssExpression, 'Alef'); | ||
| expect( | ||
| const Font(lineHeight: LineHeight(1.5, inPixels: false)).cssExpression, | ||
| '', | ||
| ); | ||
| }); | ||
|
|
||
| test('font CSS includes style and variant in shorthand order', () { | ||
| expect( | ||
| const Font( | ||
| size: 16, | ||
| weight: FontWeight.bold, | ||
| style: FontStyle.italic, | ||
| variant: FontVariant.smallCaps, | ||
| family: ['Alef'], | ||
| ).cssExpression, | ||
| 'italic small-caps 700 16px Alef', | ||
| ); | ||
| }); | ||
| } | ||
|
palmoni5 marked this conversation as resolved.
Resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.