Repository navigation
[coverage] Use getVersion() when pinging the service API - #2902
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the connection check in pkgs/coverage/lib/src/collect.dart to call service.getVersion() instead of service.getVM() when checking the service availability with a timeout. There are no review comments provided, and I have no additional feedback to offer.
PR HealthPublish ✔️
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Unused Dependencies ✔️
For details on how to fix these, see dependency_validator. This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with |
kevmoo
left a comment
There was a problem hiding this comment.
Awesome! Sure that getVersion has been around for the dependency range you have? That's my only question (unverified)
Good question. Yeah, git blame says |
We're calling
getVM()repeatedly to wait for the VM service API to become available. Turns out that's an expensive call.getVersion()is much cheaper. dart-lang/sdk#64965