Skip to content

fix: remove deprecated smart-vercel action usage#28

Merged
fewensa merged 1 commit intomainfrom
ohh-17-fix-smart-vercel-deprecations
Mar 24, 2026
Merged

fix: remove deprecated smart-vercel action usage#28
fewensa merged 1 commit intomainfrom
ohh-17-fix-smart-vercel-deprecations

Conversation

@fewensa
Copy link
Copy Markdown
Collaborator

@fewensa fewensa commented Mar 24, 2026

Summary\n- replace deprecated output commands with \ in \n- upgrade the sticky PR comment action to a Node 24 compatible release\n- replace deprecated \ with \n\n## Validation\n- git diff --check\n- rg -n "set-output|sticky-pull-request-comment@v2|--confirm" actions/smart-vercel/action.yml\n

@fewensa fewensa merged commit 3806edd into main Mar 24, 2026
6 checks passed
@fewensa fewensa deleted the ohh-17-fix-smart-vercel-deprecations branch March 24, 2026 07:47
fewensa added a commit to ringecosystem/degov-home that referenced this pull request Mar 24, 2026
Summary:
- switch all deploy workflows from the temporary smart-vercel commit pin
  back to darwinia-network/devops/actions/smart-vercel@main
- keep the earlier actions/checkout@v5 upgrade and deploy inputs unchanged

Rationale:
- the upstream smart-vercel deprecation fix is now merged in
  darwinia-network/devops#28
- the latest human guidance on OHH-17 asked degov-home to consume the
  merged upstream action directly instead of pinning a temporary commit

Tests:
- pnpm verify
- pnpm exec prettier --check .github/workflows/deploy-dev.yml
  .github/workflows/deploy-stg.yml .github/workflows/deploy-prd.yml
- git diff --check
fewensa added a commit that referenced this pull request Mar 24, 2026
Summary:
- switch preview comment rendering to a helper script that emits raw
  multiline YAML-style entries instead of percent-encoded text
- normalize preview links before exporting action outputs and keep optional
  preview section metadata in the rendered entry
- add a shell regression script covering yaml formatting and link
  normalization

Rationale:
- sticky PR comments should append readable list entries instead of literal
  %0A sequences after the output handling change from PR #28
- moving the formatter into a reusable script keeps the action logic small
  and gives the repo a deterministic regression target

Tests:
- bash scripts/test-smart-vercel-comment-format.sh
- git diff --check
boundless-forest pushed a commit to ringecosystem/degov-home that referenced this pull request Mar 24, 2026
* fix(ci): pin smart-vercel deprecation fix

* fix(ci): use merged smart-vercel action on main

Summary:
- switch all deploy workflows from the temporary smart-vercel commit pin
  back to darwinia-network/devops/actions/smart-vercel@main
- keep the earlier actions/checkout@v5 upgrade and deploy inputs unchanged

Rationale:
- the upstream smart-vercel deprecation fix is now merged in
  darwinia-network/devops#28
- the latest human guidance on OHH-17 asked degov-home to consume the
  merged upstream action directly instead of pinning a temporary commit

Tests:
- pnpm verify
- pnpm exec prettier --check .github/workflows/deploy-dev.yml
  .github/workflows/deploy-stg.yml .github/workflows/deploy-prd.yml
- git diff --check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant