Skip to content

fix exit before apply#735

Merged
vivekgsharma merged 1 commit intov1.0-devfrom
vivek/fix-exit-before-apply
Mar 3, 2026
Merged

fix exit before apply#735
vivekgsharma merged 1 commit intov1.0-devfrom
vivek/fix-exit-before-apply

Conversation

@vivekgsharma
Copy link
Copy Markdown
Collaborator

@vivekgsharma vivekgsharma commented Mar 3, 2026

fix exits before the changes are applied during devnet creation

Summary by CodeRabbit

  • Chores
    • Updated devnet deployment workflow configuration with Terraform CLI environment variable settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 466ec24 and a883620.

📒 Files selected for processing (1)
  • .github/workflows/create-devnet.yml

📝 Walkthrough

Walkthrough

A GitHub Actions workflow configuration update to add environment variables enabling automatic approval for Terraform operations during the Deploy devnet step, removing the need for manual approval prompts.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/create-devnet.yml
Added two environment variables to the Deploy devnet step: TF_IN_AUTOMATION="true" to indicate Terraform is running in an automation context, and TF_CLI_ARGS_apply="-auto-approve" to automatically approve Terraform apply operations without user interaction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 With -auto-approve in place so fine,
Terraform applies without a sign,
No pauses, no prompts to delay the day—
The devnet deploys in the CI way! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix exit before apply' is vague and doesn't clearly convey what the actual change is. While the PR description clarifies the intent, the title itself uses generic phrasing that doesn't indicate the specific technical fix (environment variables for Terraform automation). Consider using a more descriptive title such as 'Add Terraform automation environment variables to devnet creation workflow' to better reflect the actual changes being made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vivek/fix-exit-before-apply

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vivekgsharma vivekgsharma merged commit a883620 into v1.0-dev Mar 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant