Skip to content

feat(sdk): add client-side validation to state transition construction methods #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thepastaclaw wants to merge 10 commits into
base: v3.1-dev
Choose a base branch
from
+678 −248
Draft

feat(sdk): add client-side validation to state transition construction methods #3096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c6808c9
fix(dpp): validate public key security levels client-side in Identity…
thepastaclaw Feb 17, 2026
3f3f355
fix(dpp): add client-side key validation to identity create transitions
thepastaclaw Feb 17, 2026
f48de0b
fix(dpp): remove underscore prefix from now-used platform_version par…
thepastaclaw Feb 17, 2026
75c96f9
chore: remove underscore prefix from now-used platform_version params
thepastaclaw Feb 17, 2026
5b4ac16
feat(sdk): add client-side validate_structure() to remaining state tr…
thepastaclaw Feb 18, 2026
0216ce0
test(dpp,drive-abci): fix test fixtures for client-side validate_stru…
thepastaclaw Feb 21, 2026
bf8d0ed
test(drive-abci): adapt address transition tests to client-side valid…
thepastaclaw Feb 21, 2026
46c9416
style(drive-abci): apply cargo fmt
thepastaclaw Feb 21, 2026
a027428
fix(tests): adapt strategy tests for client-side validation
thepastaclaw Feb 21, 2026
ef34336
style: apply cargo fmt to strategy.rs
thepastaclaw Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...ion/state_transitions/address_funds/address_credit_withdrawal_transition/v0/v0_methods.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ use crate::serialization::Signable;
use crate::state_transition::address_credit_withdrawal_transition::methods::AddressCreditWithdrawalTransitionMethodsV0;
use crate::state_transition::address_credit_withdrawal_transition::v0::AddressCreditWithdrawalTransitionV0;
#[cfg(feature = "state-transition-signing")]
use crate::state_transition::StateTransitionStructureValidation;
#[cfg(feature = "state-transition-signing")]
use crate::withdrawal::Pooling;
#[cfg(feature = "state-transition-signing")]
use crate::{
Expand All @@ -35,7 +37,7 @@ impl AddressCreditWithdrawalTransitionMethodsV0 for AddressCreditWithdrawalTrans
output_script: CoreScript,
signer: &S,
user_fee_increase: UserFeeIncrease,
_platform_version: &PlatformVersion,
platform_version: &PlatformVersion,
) -> Result<StateTransition, ProtocolError> {
tracing::debug!("try_from_inputs_with_signer: Started");
tracing::debug!(
Expand Down Expand Up @@ -66,6 +68,14 @@ impl AddressCreditWithdrawalTransitionMethodsV0 for AddressCreditWithdrawalTrans
.map(|address| signer.sign_create_witness(address, &signable_bytes))
.collect::<Result<Vec<AddressWitness>, ProtocolError>>()?;

// Validate the fully-constructed transition structure
let validation_result =
address_credit_withdrawal_transition.validate_structure(platform_version);
if !validation_result.is_valid() {
let first_error = validation_result.errors.into_iter().next().unwrap();
return Err(ProtocolError::ConsensusError(Box::new(first_error)));
}

tracing::debug!("try_from_inputs_with_signer: Successfully created transition");
Ok(address_credit_withdrawal_transition.into())
}
Expand Down
11 changes: 10 additions & 1 deletion ...ate_transitions/address_funds/address_funding_from_asset_lock_transition/v0/v0_methods.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ use crate::serialization::Signable;
use crate::state_transition::address_funding_from_asset_lock_transition::methods::AddressFundingFromAssetLockTransitionMethodsV0;
use crate::state_transition::address_funding_from_asset_lock_transition::v0::AddressFundingFromAssetLockTransitionV0;
#[cfg(feature = "state-transition-signing")]
use crate::state_transition::StateTransitionStructureValidation;
#[cfg(feature = "state-transition-signing")]
use crate::{prelude::UserFeeIncrease, state_transition::StateTransition, ProtocolError};
#[cfg(feature = "state-transition-signing")]
use dashcore::signer;
Expand All @@ -30,7 +32,7 @@ impl AddressFundingFromAssetLockTransitionMethodsV0 for AddressFundingFromAssetL
fee_strategy: AddressFundsFeeStrategy,
signer: &S,
user_fee_increase: UserFeeIncrease,
_platform_version: &PlatformVersion,
platform_version: &PlatformVersion,
) -> Result<StateTransition, ProtocolError> {
tracing::debug!("try_from_asset_lock_with_signer: Started");
tracing::debug!(
Expand Down Expand Up @@ -64,6 +66,13 @@ impl AddressFundingFromAssetLockTransitionMethodsV0 for AddressFundingFromAssetL
.map(|address| signer.sign_create_witness(address, &signable_bytes))
.collect::<Result<Vec<AddressWitness>, ProtocolError>>()?;

// Validate the fully-constructed transition structure
let validation_result = address_funding_transition.validate_structure(platform_version);
if !validation_result.is_valid() {
let first_error = validation_result.errors.into_iter().next().unwrap();
return Err(ProtocolError::ConsensusError(Box::new(first_error)));
}

tracing::debug!("try_from_asset_lock_with_signer: Successfully created transition");
Ok(address_funding_transition.into())
}
Expand Down
Loading
Loading