Skip to content

Comments

feat: update dependencies to use local paths instead of git sources#3105

Open
QuantumExplorer wants to merge 1 commit intochore/core-worksfrom
featupdate-dependencies-to-local-paths
Open

feat: update dependencies to use local paths instead of git sources#3105
QuantumExplorer wants to merge 1 commit intochore/core-worksfrom
featupdate-dependencies-to-local-paths

Conversation

@QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

This update changes the dependency management for several packages to use local paths instead of fetching from a remote Git repository.

What was done?

  • Updated Cargo.toml files across multiple packages to replace Git dependencies with local paths for dashcore, dash-spv, key-wallet, and key-wallet-manager.
  • Removed the Git source URLs for the dashcore library and its related packages.
  • Added a new initializer in the Swift Wallet class to manage ownership of FFI wallet handles.

How Has This Been Tested?

The changes have been tested by building the project and running existing unit tests to ensure that the local paths resolve correctly and that functionality remains intact.

Breaking Changes

None

Checklist

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have added or updated relevant unit/integration/functional/e2e tests

    For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch featupdate-dependencies-to-local-paths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@lklimek lklimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks way too much stuff when doing a build. We cannot refer do another repos by local path, as it is not guaranteed these are checked out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants