feat(sdk): add client-side validate_base_structure for document and token transitions

.gitignore

@@ -85,3 +85,4 @@ packages/wasm-sdk/extracted_definitions.json
 
 # gRPC coverage report
 grpc-coverage-report.txt
+worktrees/

packages/rs-sdk/Cargo.toml

@@ -9,6 +9,7 @@ arc-swap = { version = "1.7.1" }
 chrono = { version = "0.4.38" }
 dpp = { path = "../rs-dpp", default-features = false, features = [
   "dash-sdk-features",
+  "validation",
 ] }
 dapi-grpc = { path = "../dapi-grpc", default-features = false }
 rs-dapi-client = { path = "../rs-dapi-client", default-features = false }

packages/rs-sdk/src/platform/documents/transitions/create.rs

@@ -167,6 +167,25 @@ impl DocumentCreateTransitionBuilder {
             self.state_transition_creation_options,
         )?;
 
+        // Validate the transition structure before returning
+        let validation_result = match &state_transition {
+            StateTransition::Batch(batch_transition) => {
+                batch_transition.validate_base_structure(platform_version)?
+            }
+            _ => {
+                return Err(Error::Protocol(
+                    dpp::ProtocolError::InvalidStateTransitionType(
+                        "expected Batch transition".to_string(),
+                    ),
+                ));
+            }
+        };
+        if let Some(first_error) = validation_result.errors.into_iter().next() {
+            return Err(Error::Protocol(dpp::ProtocolError::ConsensusError(
+                Box::new(first_error),
+            )));
+        }
+
         Ok(state_transition)
     }
 }
@@ -249,3 +268,11 @@ impl Sdk {
         }
     }
 }
+
+#[cfg(test)]
+mod validation_tests {
+    #[test]
+    fn validate_base_structure_error_case() {
+        super::super::tests::assert_document_create_validate_base_structure_error();
+    }
+}

packages/rs-sdk/src/platform/documents/transitions/delete.rs

@@ -207,6 +207,25 @@ impl DocumentDeleteTransitionBuilder {
             self.state_transition_creation_options,
         )?;
 
+        // Validate the transition structure before returning
+        let validation_result = match &state_transition {
+            StateTransition::Batch(batch_transition) => {
+                batch_transition.validate_base_structure(platform_version)?
+            }
+            _ => {
+                return Err(Error::Protocol(
+                    dpp::ProtocolError::InvalidStateTransitionType(
+                        "expected Batch transition".to_string(),
+                    ),
+                ));
+            }
+        };
+        if let Some(first_error) = validation_result.errors.into_iter().next() {
+            return Err(Error::Protocol(dpp::ProtocolError::ConsensusError(
+                Box::new(first_error),
+            )));
+        }
+
         Ok(state_transition)
     }
 }
@@ -285,3 +304,11 @@ impl Sdk {
         }
     }
 }
+
+#[cfg(test)]
+mod validation_tests {
+    #[test]
+    fn validate_base_structure_error_case() {
+        super::super::tests::assert_document_delete_validate_base_structure_error();
+    }
+}

packages/rs-sdk/src/platform/documents/transitions/mod.rs

@@ -3,6 +3,8 @@ pub mod delete;
 pub mod purchase;
 pub mod replace;
 pub mod set_price;
+#[cfg(test)]
+mod tests;
 pub mod transfer;
 
 pub use create::{DocumentCreateResult, DocumentCreateTransitionBuilder};

packages/rs-sdk/src/platform/documents/transitions/purchase.rs

@@ -221,6 +221,25 @@ impl DocumentPurchaseTransitionBuilder {
             self.state_transition_creation_options,
         )?;
 
+        // Validate the transition structure before returning
+        let validation_result = match &state_transition {
+            StateTransition::Batch(batch_transition) => {
+                batch_transition.validate_base_structure(platform_version)?
+            }
+            _ => {
+                return Err(Error::Protocol(
+                    dpp::ProtocolError::InvalidStateTransitionType(
+                        "expected Batch transition".to_string(),
+                    ),
+                ));
+            }
+        };
+        if let Some(first_error) = validation_result.errors.into_iter().next() {
+            return Err(Error::Protocol(dpp::ProtocolError::ConsensusError(
+                Box::new(first_error),
+            )));
+        }
+
         Ok(state_transition)
     }
 }
@@ -302,3 +321,11 @@ impl Sdk {
         }
     }
 }
+
+#[cfg(test)]
+mod validation_tests {
+    #[test]
+    fn validate_base_structure_error_case() {
+        super::super::tests::assert_document_purchase_validate_base_structure_error();
+    }
+}

packages/rs-sdk/src/platform/documents/transitions/replace.rs

@@ -160,6 +160,25 @@ impl DocumentReplaceTransitionBuilder {
             self.state_transition_creation_options,
         )?;
 
+        // Validate the transition structure before returning
+        let validation_result = match &state_transition {
+            StateTransition::Batch(batch_transition) => {
+                batch_transition.validate_base_structure(platform_version)?
+            }
+            _ => {
+                return Err(Error::Protocol(
+                    dpp::ProtocolError::InvalidStateTransitionType(
+                        "expected Batch transition".to_string(),
+                    ),
+                ));
+            }
+        };
+        if let Some(first_error) = validation_result.errors.into_iter().next() {
+            return Err(Error::Protocol(dpp::ProtocolError::ConsensusError(
+                Box::new(first_error),
+            )));
+        }
+
         Ok(state_transition)
     }
 }
@@ -248,3 +267,11 @@ impl Sdk {
         }
     }
 }
+
+#[cfg(test)]
+mod validation_tests {
+    #[test]
+    fn validate_base_structure_error_case() {
+        super::super::tests::assert_document_replace_validate_base_structure_error();
+    }
+}

packages/rs-sdk/src/platform/documents/transitions/set_price.rs

@@ -208,6 +208,25 @@ impl DocumentSetPriceTransitionBuilder {
             self.state_transition_creation_options,
         )?;
 
+        // Validate the transition structure before returning
+        let validation_result = match &state_transition {
+            StateTransition::Batch(batch_transition) => {
+                batch_transition.validate_base_structure(platform_version)?
+            }
+            _ => {
+                return Err(Error::Protocol(
+                    dpp::ProtocolError::InvalidStateTransitionType(
+                        "expected Batch transition".to_string(),
+                    ),
+                ));
+            }
+        };
+        if let Some(first_error) = validation_result.errors.into_iter().next() {
+            return Err(Error::Protocol(dpp::ProtocolError::ConsensusError(
+                Box::new(first_error),
+            )));
+        }
+
         Ok(state_transition)
     }
 }
@@ -286,3 +305,11 @@ impl Sdk {
         }
     }
 }
+
+#[cfg(test)]
+mod validation_tests {
+    #[test]
+    fn validate_base_structure_error_case() {
+        super::super::tests::assert_document_set_price_validate_base_structure_error();
+    }
+}