Skip to content

Comments

ci: fail gRPC coverage check on missing queries, remove PR comment#3135

Open
thepastaclaw wants to merge 1 commit intodashpay:v3.1-devfrom
thepastaclaw:ci/grpc-coverage-fail-no-comment
Open

ci: fail gRPC coverage check on missing queries, remove PR comment#3135
thepastaclaw wants to merge 1 commit intodashpay:v3.1-devfrom
thepastaclaw:ci/grpc-coverage-fail-no-comment

Conversation

@thepastaclaw
Copy link
Contributor

@thepastaclaw thepastaclaw commented Feb 20, 2026

Option A (alternative to #3136)

Simplify the gRPC coverage workflow:

  • Let the Python script's exit code drive pass/fail directly (fails if any new queries are missing)
  • Remove the PR comment step entirely — coverage report is available as a build artifact
  • Drop pull-requests: write permission (no longer needed)

This solves the fork PR failure since no comment is attempted. Also makes the workflow simpler — missing coverage shows up as a red CI check rather than a comment.

Validation

What was tested:

  • Check gRPC query coverage CI workflow — validates that the Python script exit code correctly gates coverage enforcement
  • Fork PR simulation: confirmed no pull-requests: write permission errors occur since comment step is removed

Results:

  • Check gRPC query coverage — pass (10s, GitHub Actions CI)
  • Build JS packages / Build JS — pass (11m11s)
  • JS dependency versions check — pass
  • Rust crates security audit — pass
  • All other applicable CI checks passed

Environment: GitHub Actions CI (ubuntu-latest)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 20, 2026

Warning

Rate limit exceeded

@thepastaclaw has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 28 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thepastaclaw
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 21, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is my preferred between the two PRs

Simplify the gRPC coverage workflow:
- Let the Python script's exit code drive pass/fail directly
- Remove the PR comment step entirely (coverage report is
  available as a build artifact)
- Drop pull-requests: write permission (no longer needed)

The job now fails if any new queries are missing implementation,
which is visible in the CI status check without needing a comment.
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants