ci: fail gRPC coverage check on missing queries, remove PR comment#3135
ci: fail gRPC coverage check on missing queries, remove PR comment#3135thepastaclaw wants to merge 1 commit intodashpay:v3.1-devfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
PastaPastaPasta
left a comment
There was a problem hiding this comment.
this is my preferred between the two PRs
Simplify the gRPC coverage workflow: - Let the Python script's exit code drive pass/fail directly - Remove the PR comment step entirely (coverage report is available as a build artifact) - Drop pull-requests: write permission (no longer needed) The job now fails if any new queries are missing implementation, which is visible in the CI status check without needing a comment.
9be6d34 to
97e3448
Compare
PastaPastaPasta
left a comment
There was a problem hiding this comment.
I think this makes sense
Option A (alternative to #3136)
Simplify the gRPC coverage workflow:
pull-requests: writepermission (no longer needed)This solves the fork PR failure since no comment is attempted. Also makes the workflow simpler — missing coverage shows up as a red CI check rather than a comment.
Validation
What was tested:
Check gRPC query coverageCI workflow — validates that the Python script exit code correctly gates coverage enforcementpull-requests: writepermission errors occur since comment step is removedResults:
Check gRPC query coverage— pass (10s, GitHub Actions CI)Build JS packages / Build JS— pass (11m11s)JS dependency versions check— passRust crates security audit— passEnvironment: GitHub Actions CI (ubuntu-latest)