Skip to content

Comments

fix(dashmate): lower HP node RAM requirement to 7.3GB#3153

Merged
QuantumExplorer merged 2 commits intov3.1-devfrom
fix-ram-requirement
Feb 24, 2026
Merged

fix(dashmate): lower HP node RAM requirement to 7.3GB#3153
QuantumExplorer merged 2 commits intov3.1-devfrom
fix-ram-requirement

Conversation

@ktechmidas
Copy link
Collaborator

@ktechmidas ktechmidas commented Feb 24, 2026

Nodes with a nominal 8GB allocation typically only have ~7.6GB usable due to OS and firmware overhead, causing them to fail the system requirements check. Lower the threshold to 7.3GB to accommodate this.

Issue being fixed or feature implemented

Nodes will give errors despite being very close to the 8GB requirements for evonodes due to variances from VM hosts. Done the same for regular masternodes (3.6GB instead of 4)

What was done?

Lowered evonodes to 7.3GB required
Lowered masternodes to 3.6GB required

How Has This Been Tested?

Tested on local

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Updated system memory requirements for HP and non-HP configurations to lower thresholds.

Nodes with a nominal 8GB allocation typically only have ~7.6GB usable
due to OS and firmware overhead, causing them to fail the system
requirements check. Lower the threshold to 7.3GB to accommodate this.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added this to the v3.1.0 milestone Feb 24, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1520a1 and b1ef1c3.

📒 Files selected for processing (1)
  • packages/dashmate/src/doctor/verifySystemRequirementsFactory.js

📝 Walkthrough

Walkthrough

This change reduces the minimum RAM requirements for system verification checks in dashmate. MINIMUM_RAM thresholds are lowered from 8 GB to 7.3 GB for HP configurations and from 4 GB to 3.6 GB for non-HP configurations, while all other system requirement thresholds remain unchanged.

Changes

Cohort / File(s) Summary
System Requirements Verification
packages/dashmate/src/doctor/verifySystemRequirementsFactory.js
Reduced minimum RAM requirements: HP configurations from 8 GB to 7.3 GB, non-HP configurations from 4 GB to 3.6 GB.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hops with glee, the RAM now light,
Less is more, the memory's right,
Thresholds down, but systems run,
Efficiency checks—we're having fun! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: lowering the HP node RAM requirement from 8GB to 7.3GB, which aligns with the primary modification in the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-ram-requirement

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Same reasoning as the HP node change - nominal 4GB allocations from
hosting providers typically only provide ~3.7-3.8GB usable RAM.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@QuantumExplorer QuantumExplorer merged commit 0fa82e6 into v3.1-dev Feb 24, 2026
27 of 29 checks passed
@QuantumExplorer QuantumExplorer deleted the fix-ram-requirement branch February 24, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants