fix(dashmate): lower HP node RAM requirement to 7.3GB#3153
fix(dashmate): lower HP node RAM requirement to 7.3GB#3153QuantumExplorer merged 2 commits intov3.1-devfrom
Conversation
Nodes with a nominal 8GB allocation typically only have ~7.6GB usable due to OS and firmware overhead, causing them to fail the system requirements check. Lower the threshold to 7.3GB to accommodate this. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change reduces the minimum RAM requirements for system verification checks in dashmate. MINIMUM_RAM thresholds are lowered from 8 GB to 7.3 GB for HP configurations and from 4 GB to 3.6 GB for non-HP configurations, while all other system requirement thresholds remain unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Same reasoning as the HP node change - nominal 4GB allocations from hosting providers typically only provide ~3.7-3.8GB usable RAM. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Nodes with a nominal 8GB allocation typically only have ~7.6GB usable due to OS and firmware overhead, causing them to fail the system requirements check. Lower the threshold to 7.3GB to accommodate this.
Issue being fixed or feature implemented
Nodes will give errors despite being very close to the 8GB requirements for evonodes due to variances from VM hosts. Done the same for regular masternodes (3.6GB instead of 4)
What was done?
Lowered evonodes to 7.3GB required
Lowered masternodes to 3.6GB required
How Has This Been Tested?
Tested on local
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit