Skip to content

funasr support payload.input and bug fix in transcription#144

Open
songguocola wants to merge 2 commits into
dashscope:mainfrom
songguocola:dev/audio_0618
Open

funasr support payload.input and bug fix in transcription#144
songguocola wants to merge 2 commits into
dashscope:mainfrom
songguocola:dev/audio_0618

Conversation

@songguocola

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a wait_timeout parameter to the wait methods across various AIGC and audio task classes, as well as the base API client, allowing users to specify a maximum wait time for task completion. It also updates the request data serialization to extract raw_input from parameters. The review feedback highlights a bug in api_request_data.py where the original parameters dictionary is not updated with the popped raw_input, and potential TypeError issues in base_api.py if wait_timeout is passed as None.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dashscope/api_entities/api_request_data.py
Comment thread dashscope/client/base_api.py
Comment thread dashscope/client/base_api.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant