Skip to content

Fix memray CI; move back from mamba to conda#9258

Merged
crusaderky merged 6 commits into
dask:mainfrom
crusaderky:extras-ci
May 4, 2026
Merged

Fix memray CI; move back from mamba to conda#9258
crusaderky merged 6 commits into
dask:mainfrom
crusaderky:extras-ci

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky commented May 4, 2026

memray (which is singled out in CI as there are no windows packages for it) hangs in CI upon install.
This is because it upgrades a bunch of packages that are pinned in the mindeps environment. Move it to the unpinned 3.11 (3.10 is not a great choice, as it includes a wealth of extra GPU-specific stack).

This PR also

  • adds caching to extra dependencies installation (memray, mindeps-numpy, mindeps-pandas)
  • moves back from mamba to conda, as conda now internally uses the mamba engine

@crusaderky crusaderky requested a review from fjetter as a code owner May 4, 2026 09:44
@crusaderky crusaderky added the tests Unit tests and/or continuous integration label May 4, 2026
with:
path: ${{ env.CONDA }}/envs
key: conda-${{ matrix.os }}-${{ matrix.environment }}-${{ matrix.label }}-${{ steps.get-date.outputs.today }}-${{ hashFiles(env.CONDA_FILE) }}-${{ env.CACHE_NUMBER }}
key: conda-${{ matrix.os }}-${{ matrix.environment }}-${{ matrix.label }}-${{ matrix.extra_packages }}-${{ steps.get-date.outputs.today }}-${{ hashFiles(env.CONDA_FILE) }}-${{ env.CACHE_NUMBER }}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix bug where the contents of the extra_packages may change (e.g. which pinned version of numpy and pandas to install) but it is not noticed by CI until the next day.

@crusaderky crusaderky changed the title Fix memray CI Fix memray CI; move back from mamba to conda May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    31 files      31 suites   11h 32m 51s ⏱️
 4 120 tests  4 011 ✅   105 💤 4 ❌
59 800 runs  57 308 ✅ 2 487 💤 5 ❌

For more details on these failures, see this check.

Results for commit a60df06.

@crusaderky crusaderky merged commit d6308a9 into dask:main May 4, 2026
32 of 38 checks passed
@crusaderky crusaderky deleted the extras-ci branch May 4, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Unit tests and/or continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant