Skip to content

Handle empty MultiProgressWidget shutdown #9271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
peter941221 wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Draft

Handle empty MultiProgressWidget shutdown #9271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d66c17c
Handle empty MultiProgressWidget shutdown
peter941221 May 25, 2026
3ab7019
Avoid default client lookup in empty widget test
peter941221 May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion distributed/diagnostics/progressbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,9 @@ def __init__(
**kwargs,
):
super().__init__(keys, scheduler, **kwargs)
from ipywidgets import VBox
from ipywidgets import HTML, VBox

self.elapsed_time = HTML("")
self.widget = VBox([])

def make_widget(self, all):
Expand Down
6 changes: 6 additions & 0 deletions distributed/diagnostics/tests/test_progress_widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,12 @@ def test_values(client):
assert p.status == "error"


def test_multi_progressbar_widget_empty_keys_does_not_error():
p = MultiProgressWidget([], scheduler="tcp://127.0.0.1:1")
p._draw_stop(remaining={}, status="finished")
assert "Finished" in p.elapsed_time.value


def test_progressbar_done(client):
L = [client.submit(inc, i) for i in range(5)]
wait(L)
Expand Down
Loading