drop dependency on 'urllib3'#9273
Merged
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 31 files ±0 31 suites ±0 10h 41m 51s ⏱️ + 9m 9s For more details on these failures and errors, see this check. Results for commit 4876d19. ± Comparison against base commit d8fabe2. |
Collaborator
That's fine, test_report.py is currently broken and needs a heavy maintenance pass anyway. |
crusaderky
approved these changes
May 26, 2026
Collaborator
crusaderky
left a comment
There was a problem hiding this comment.
I've also tested this manually without mocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9267
distributedhas a hard runtime dependency onurllib3only for--preload(see #3755). That's only used for a single GET request with retries. This proposes replacing it withurllibfrom the standard library (h/t @jrbourbeau for the suggestion) and removing theurllib3dependency.Notes for Reviewers
pre-commit run --all-filesI left one optional use in test-only code
Intentionally left this:
distributed/continuous_integration/scripts/test_report.py
Line 22 in d8fabe2
And the dependency in the conda env for running that:
distributed/continuous_integration/scripts/test-report-environment.yml
Line 10 in d8fabe2
How I tested this