uvloop tests#9278
Merged
Merged
Conversation
This reverts commit e8c5117.
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 31 files ± 0 31 suites ±0 10h 52m 6s ⏱️ + 11m 34s For more details on these failures, see this check. Results for commit fb50daa. ± Comparison against base commit c12638f. This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both.This pull request removes 1 skipped test and adds 5 skipped tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only test for uvloop is not triggered by CI, was broken, and was not covering the major use case of CLI wrappers.
Closes #9218
This PR still does not trigger the tests in CI due to uvloop not being available on Windows, which does not play well with distributed's legacy CI. #9276 starts running it.