CARDS-2130: Increase test coverage of cards-data-model-subjects-impl - #1392
Open
sofi2002sofi wants to merge 2 commits into
Open
CARDS-2130: Increase test coverage of cards-data-model-subjects-impl#1392sofi2002sofi wants to merge 2 commits into
sofi2002sofi wants to merge 2 commits into
Conversation
Contributor
|
|
Contributor
|
jacoco.zip |
sofi2002sofi
force-pushed
the
CARDS-2130-subjects-tests
branch
from
August 5, 2023 20:53
b9e891a to
24be156
Compare
veronikaslc
force-pushed
the
CARDS-2130-subjects-tests
branch
2 times, most recently
from
December 6, 2025 06:33
d036535 to
0f08fbf
Compare
Modernize the revived tests and complete the module coverage to 100%: - migrate the tests to the current platform APIs: jakarta.json, Mockito 5, sling-mock 4 - drop the Mockito runner in favor of plain mocks with reflection injection, since concurrently running runners collide on Mockito's global listener registry under the parallel surefire configuration - raise the sling-mock resource resolver factory timeout, the default 500ms is not always enough when several Oak-backed test contexts start in parallel - add tests for the previously uncovered classes: SubjectIdPatternValidator and its provider, and SubjectsWithModifiedFormsRetriever - cover the previously untested paths: identifiers joined across several ancestors, computation failures while leaving a subject node, manual result counting stopping at the result limit, quick search skipping and null identifiers, non-form children skipped during text serialization - fix a test that stubbed the wrong isNodeType argument and thus never exercised the exception handling it claimed to test - rename the remaining vague test names - remove the module's coverage exemption, restoring the default 1.00 required instruction coverage ratio
sdumitriu
force-pushed
the
CARDS-2130-subjects-tests
branch
from
July 27, 2026 21:18
0f08fbf to
dfbc8a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.