CARDS-2175: form-completion-status tests - #1453
Open
sofi2002sofi wants to merge 2 commits into
Open
Conversation
Contributor
|
rebased on the latest FAILURE! - in io.uhndata.cards.formcompletionstatus.AnswerCompletionStatusEditorTest [ERROR] enterForFormNodeAddsDifferentStatusFlags(io.uhndata.cards.formcompletionstatus.AnswerCompletionStatusEditorTest) Time elapsed: 0.373 s <<< FAILURE! |
sofi2002sofi
force-pushed
the
CARDS-2175-form-completion-status-test
branch
from
July 2, 2023 10:40
865c44d to
8befaf5
Compare
veronikaslc
force-pushed
the
CARDS-2175-form-completion-status-test
branch
2 times, most recently
from
December 6, 2025 06:38
0590bc5 to
1e0606e
Compare
Modernize the revived tests and complete the module coverage to 100%: - migrate the tests to the current platform APIs: jakarta.json, Mockito 5, sling-mock 4 - drop the Mockito runner in favor of plain mocks with reflection injection, since concurrently running runners collide on Mockito's global listener registry under the parallel surefire configuration - raise the sling-mock resource resolver factory timeout, the default 500ms is not always enough when several Oak-backed test contexts start in parallel - add tests for the previously uncovered classes: RegExpValueValidator, RangeMinMaxAnswersValidator, and the AnswerValidator default methods - cover the previously untested paths: the includes/excludes comparator family, empty and multivalued operands, unknown comparators, nested answers and questions, broken conditional definitions and values, answer options and suggested-only limits in MinMaxValueValidator, submitted forms and conditional sections in the completion status editor - extend the date fallback in conditional values: fixed dates that are not in the strict JCR format are now parsed with the lenient supported formats instead of failing the comparison with a ClassCastException, in the spirit of the CARDS-2877 fix - remove dead code: the never-invoked debugging toString methods, an unreachable summarize catch block, and a stream reduce combiner that can never run on a sequential stream; guard against sections that belong to no questionnaire - rename the remaining vague test names and drop the meaningless constructor smoke test - remove the module's coverage exemption, restoring the default 1.00 required instruction coverage ratio
sdumitriu
force-pushed
the
CARDS-2175-form-completion-status-test
branch
from
July 27, 2026 23:06
1e0606e to
0c3a1ec
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| TEST_ANSWER_SECTION_NAME, answerSectionNodeBuilder.getNodeState())); | ||
| } | ||
|
|
||
| private NodeBuilder getFormNodeBuilderWithAnswerAndAnswerSectionChildren(Object answerValue) |
| assertFalse(evaluateConditionalWithBrokenFixedValue("date", "2023-01-01")); | ||
| } | ||
|
|
||
| private boolean evaluateConditionalWithBrokenFixedValue(final String dataType, final String comparableValue) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.