CARDS-2571: Reference Questions do not work inside Conditional Sections - #1802
Open
acrowthe wants to merge 3 commits into
Open
CARDS-2571: Reference Questions do not work inside Conditional Sections#1802acrowthe wants to merge 3 commits into
acrowthe wants to merge 3 commits into
Conversation
Contributor
Contributor
Author
Contributor
acrowthe
force-pushed
the
CARDS-2571
branch
2 times, most recently
from
November 8, 2024 19:02
011e4d3 to
2dc5c5b
Compare
Contributor
Author
|
Could not reproduce the bug after latest rebase and related changes - please let me know if you encounter it again. |
- Update reference question initialization code to check for unlinked reference questions
any time a form is edited, not just when a form is created
- Search for any reference questions on the form that do not have an answer
- Check if the missing questions have an existing answer section. If so, generate an answer
- Try to find a source answer for any existing or newly created unanswered reference answers
- Prioritize pulling source answers from forms that are already referenced by other
reference answers in this form for consistency
- Add test case in ReferenceTestCopied form
Fix bug where incorrect form would be prioritized
Refactoring for improved performance Fixed a few typos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




To test:
a. Make sure the referenced text answers are from the most recent User form
b. Do not fill out the
Should the conditional section be satisfiedanswerShould the conditional section be satisfiedto truePrevious (incorrect) behaviour: